From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 18/24] drm/rockchip: dw-mipi-dsi: use specific poll helper Date: Tue, 31 Jan 2017 13:45:05 -0500 Message-ID: <20170131184505.GA20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-19-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170129132444.25251-19-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gU3VuLCBKYW4gMjksIDIwMTcgYXQgMDE6MjQ6MzhQTSArMDAwMCwgSm9obiBLZWVwaW5nIHdy b3RlOgo+IEFzIHRoZSBkb2N1bWVudGF0aW9uIGZvciByZWFkeF9wb2xsX3RpbWVvdXQgc2F5cywg d2Ugd2FudCB0byB1c2UgdGhlCj4gc3BlY2lhbGl6ZWQgbWFjcm8gZm9yIHJlYWRsIHJhdGhlciB0 aGFuIHVzaW5nIHRoZSBnZW5lcmljIHZlcnNpb24KPiBkaXJlY3RseS4KPiAKClJldmlld2VkLWJ5 OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KCj4gU2lnbmVkLW9mZi1ieTogSm9o biBLZWVwaW5nIDxqb2huQG1ldGFuYXRlLmNvbT4KPiBSZXZpZXdlZC1ieTogQ2hyaXMgWmhvbmcg PHp5d0Byb2NrLWNoaXBzLmNvbT4KPiAtLS0KPiB2MzoKPiAtIEFkZCBDaHJpcycgUmV2aWV3ZWQt YnkKPiBVbmNoYW5nZWQgaW4gdjIKPiAKPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1p cGktZHNpLmMgfCAxMCArKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2Nr Y2hpcC9kdy1taXBpLWRzaS5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNp LmMKPiBpbmRleCBkY2I2NmEyMWUxZjEuLmJlMzk1YzNjNWMwNiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gQEAgLTQ3NCwxNCArNDc0LDE0IEBAIHN0YXRpYyBp bnQgZHdfbWlwaV9kc2lfcGh5X2luaXQoc3RydWN0IGR3X21pcGlfZHNpICpkc2kpCj4gIAkJCQkg ICAgIFBIWV9VTlJTVFogfCBQSFlfVU5TSFVURE9XTlopOwo+ICAKPiAgCj4gLQlyZXQgPSByZWFk eF9wb2xsX3RpbWVvdXQocmVhZGwsIGRzaS0+YmFzZSArIERTSV9QSFlfU1RBVFVTLAo+ICsJcmV0 ID0gcmVhZGxfcG9sbF90aW1lb3V0KGRzaS0+YmFzZSArIERTSV9QSFlfU1RBVFVTLAo+ICAJCQkJ IHZhbCwgdmFsICYgTE9DSywgMTAwMCwgUEhZX1NUQVRVU19USU1FT1VUX1VTKTsKPiAgCWlmIChy ZXQgPCAwKSB7Cj4gIAkJZGV2X2Vycihkc2ktPmRldiwgImZhaWxlZCB0byB3YWl0IGZvciBwaHkg bG9jayBzdGF0ZVxuIik7Cj4gIAkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gLQlyZXQgPSByZWFk eF9wb2xsX3RpbWVvdXQocmVhZGwsIGRzaS0+YmFzZSArIERTSV9QSFlfU1RBVFVTLAo+ICsJcmV0 ID0gcmVhZGxfcG9sbF90aW1lb3V0KGRzaS0+YmFzZSArIERTSV9QSFlfU1RBVFVTLAo+ICAJCQkJ IHZhbCwgdmFsICYgU1RPUF9TVEFURV9DTEtfTEFORSwgMTAwMCwKPiAgCQkJCSBQSFlfU1RBVFVT X1RJTUVPVVRfVVMpOwo+ICAJaWYgKHJldCA8IDApIHsKPiBAQCAtNTk3LDcgKzU5Nyw3IEBAIHN0 YXRpYyBpbnQgZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3JpdGUoc3RydWN0IGR3X21pcGlfZHNp ICpkc2ksIHUzMiBoZHJfdmFsKQo+ICAJaW50IHJldDsKPiAgCXUzMiB2YWwsIG1hc2s7Cj4gIAo+ IC0JcmV0ID0gcmVhZHhfcG9sbF90aW1lb3V0KHJlYWRsLCBkc2ktPmJhc2UgKyBEU0lfQ01EX1BL VF9TVEFUVVMsCj4gKwlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQoZHNpLT5iYXNlICsgRFNJX0NN RF9QS1RfU1RBVFVTLAo+ICAJCQkJIHZhbCwgISh2YWwgJiBHRU5fQ01EX0ZVTEwpLCAxMDAwLAo+ ICAJCQkJIENNRF9QS1RfU1RBVFVTX1RJTUVPVVRfVVMpOwo+ICAJaWYgKHJldCA8IDApIHsKPiBA QCAtNjA4LDcgKzYwOCw3IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3Jp dGUoc3RydWN0IGR3X21pcGlfZHNpICpkc2ksIHUzMiBoZHJfdmFsKQo+ICAJZHNpX3dyaXRlKGRz aSwgRFNJX0dFTl9IRFIsIGhkcl92YWwpOwo+ICAKPiAgCW1hc2sgPSBHRU5fQ01EX0VNUFRZIHwg R0VOX1BMRF9XX0VNUFRZOwo+IC0JcmV0ID0gcmVhZHhfcG9sbF90aW1lb3V0KHJlYWRsLCBkc2kt PmJhc2UgKyBEU0lfQ01EX1BLVF9TVEFUVVMsCj4gKwlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQo ZHNpLT5iYXNlICsgRFNJX0NNRF9QS1RfU1RBVFVTLAo+ICAJCQkJIHZhbCwgKHZhbCAmIG1hc2sp ID09IG1hc2ssCj4gIAkJCQkgMTAwMCwgQ01EX1BLVF9TVEFUVVNfVElNRU9VVF9VUyk7Cj4gIAlp ZiAocmV0IDwgMCkgewo+IEBAIC02NjcsNyArNjY3LDcgQEAgc3RhdGljIGludCBkd19taXBpX2Rz aV9kY3NfbG9uZ193cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwKPiAgCQkJbGVuIC09IHBs ZF9kYXRhX2J5dGVzOwo+ICAJCX0KPiAgCj4gLQkJcmV0ID0gcmVhZHhfcG9sbF90aW1lb3V0KHJl YWRsLCBkc2ktPmJhc2UgKyBEU0lfQ01EX1BLVF9TVEFUVVMsCj4gKwkJcmV0ID0gcmVhZGxfcG9s bF90aW1lb3V0KGRzaS0+YmFzZSArIERTSV9DTURfUEtUX1NUQVRVUywKPiAgCQkJCQkgdmFsLCAh KHZhbCAmIEdFTl9QTERfV19GVUxMKSwgMTAwMCwKPiAgCQkJCQkgQ01EX1BLVF9TVEFUVVNfVElN RU9VVF9VUyk7Cj4gIAkJaWYgKHJldCA8IDApIHsKPiAtLSAKPiAyLjExLjAuMTk3LmdiNTU2ZGU1 LmRpcnR5Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21p dW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Tue, 31 Jan 2017 13:45:05 -0500 Subject: [PATCH v3 18/24] drm/rockchip: dw-mipi-dsi: use specific poll helper In-Reply-To: <20170129132444.25251-19-john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-19-john@metanate.com> Message-ID: <20170131184505.GA20076@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 29, 2017 at 01:24:38PM +0000, John Keeping wrote: > As the documentation for readx_poll_timeout says, we want to use the > specialized macro for readl rather than using the generic version > directly. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index dcb66a21e1f1..be395c3c5c06 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -474,14 +474,14 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) > PHY_UNRSTZ | PHY_UNSHUTDOWNZ); > > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & LOCK, 1000, PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > dev_err(dsi->dev, "failed to wait for phy lock state\n"); > return ret; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & STOP_STATE_CLK_LANE, 1000, > PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -597,7 +597,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > int ret; > u32 val, mask; > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_CMD_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -608,7 +608,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > dsi_write(dsi, DSI_GEN_HDR, hdr_val); > > mask = GEN_CMD_EMPTY | GEN_PLD_W_EMPTY; > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, (val & mask) == mask, > 1000, CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -667,7 +667,7 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > len -= pld_data_bytes; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_PLD_W_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbdAaSyG (ORCPT ); Tue, 31 Jan 2017 13:54:06 -0500 Received: from mail-qt0-f175.google.com ([209.85.216.175]:35191 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdAaSxy (ORCPT ); Tue, 31 Jan 2017 13:53:54 -0500 Date: Tue, 31 Jan 2017 13:45:05 -0500 From: Sean Paul To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 18/24] drm/rockchip: dw-mipi-dsi: use specific poll helper Message-ID: <20170131184505.GA20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-19-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129132444.25251-19-john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 01:24:38PM +0000, John Keeping wrote: > As the documentation for readx_poll_timeout says, we want to use the > specialized macro for readl rather than using the generic version > directly. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index dcb66a21e1f1..be395c3c5c06 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -474,14 +474,14 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) > PHY_UNRSTZ | PHY_UNSHUTDOWNZ); > > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & LOCK, 1000, PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > dev_err(dsi->dev, "failed to wait for phy lock state\n"); > return ret; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & STOP_STATE_CLK_LANE, 1000, > PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -597,7 +597,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > int ret; > u32 val, mask; > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_CMD_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -608,7 +608,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > dsi_write(dsi, DSI_GEN_HDR, hdr_val); > > mask = GEN_CMD_EMPTY | GEN_PLD_W_EMPTY; > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, (val & mask) == mask, > 1000, CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -667,7 +667,7 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > len -= pld_data_bytes; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_PLD_W_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS