From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 22/24] drm/rockchip: dw-mipi-dsi: support non-burst modes Date: Tue, 31 Jan 2017 14:22:55 -0500 Message-ID: <20170131192255.GF20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-23-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170129132444.25251-23-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gU3VuLCBKYW4gMjksIDIwMTcgYXQgMDE6MjQ6NDJQTSArMDAwMCwgSm9obiBLZWVwaW5nIHdy b3RlOgoKUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKPiBT aWduZWQtb2ZmLWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29tPgo+IFJldmlld2Vk LWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29tPgo+IC0tLQo+IHYzOgo+IC0gQWRk IENocmlzJyBSZXZpZXdlZC1ieQo+IFVuY2hhbmdlZCBpbiB2Mgo+IAo+ICBkcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYyB8IDE2ICsrKysrKysrKy0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgYi9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+IGluZGV4IDViYWQ5MmUyMzcwZS4uNThjYjhhY2Uy ZmU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiBAQCAtODIs NiArODIsNyBAQAo+ICAjZGVmaW5lIEZSQU1FX0JUQV9BQ0sJCQlCSVQoMTQpCj4gICNkZWZpbmUg RU5BQkxFX0xPV19QT1dFUgkJKDB4M2YgPDwgOCkKPiAgI2RlZmluZSBFTkFCTEVfTE9XX1BPV0VS X01BU0sJCSgweDNmIDw8IDgpCj4gKyNkZWZpbmUgVklEX01PREVfVFlQRV9OT05fQlVSU1RfU1lO Q19FVkVOVFMJMHgxCj4gICNkZWZpbmUgVklEX01PREVfVFlQRV9CVVJTVF9TWU5DX1BVTFNFUwkJ MHgyCj4gICNkZWZpbmUgVklEX01PREVfVFlQRV9NQVNLCQkJMHgzCj4gIAo+IEBAIC0yODYsNiAr Mjg3LDcgQEAgc3RydWN0IGR3X21pcGlfZHNpIHsKPiAgCXUzMiBmb3JtYXQ7Cj4gIAl1MTYgaW5w dXRfZGl2Owo+ICAJdTE2IGZlZWRiYWNrX2RpdjsKPiArCXVuc2lnbmVkIGxvbmcgbW9kZV9mbGFn czsKPiAgCj4gIAljb25zdCBzdHJ1Y3QgZHdfbWlwaV9kc2lfcGxhdF9kYXRhICpwZGF0YTsKPiAg fTsKPiBAQCAtNTUxLDE1ICs1NTMsMTAgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9ob3N0X2F0 dGFjaChzdHJ1Y3QgbWlwaV9kc2lfaG9zdCAqaG9zdCwKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAg CX0KPiAgCj4gLQlpZiAoIShkZXZpY2UtPm1vZGVfZmxhZ3MgJiBNSVBJX0RTSV9NT0RFX1ZJREVP X0JVUlNUKSB8fAo+IC0JICAgICEoZGV2aWNlLT5tb2RlX2ZsYWdzICYgTUlQSV9EU0lfTU9ERV9W SURFT19TWU5DX1BVTFNFKSkgewo+IC0JCWRldl9lcnIoZHNpLT5kZXYsICJkZXZpY2UgbW9kZSBp cyB1bnN1cHBvcnRlZFxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gLQo+ICAJZHNp LT5sYW5lcyA9IGRldmljZS0+bGFuZXM7Cj4gIAlkc2ktPmNoYW5uZWwgPSBkZXZpY2UtPmNoYW5u ZWw7Cj4gIAlkc2ktPmZvcm1hdCA9IGRldmljZS0+Zm9ybWF0Owo+ICsJZHNpLT5tb2RlX2ZsYWdz ID0gZGV2aWNlLT5tb2RlX2ZsYWdzOwo+ICAJZHNpLT5wYW5lbCA9IG9mX2RybV9maW5kX3BhbmVs KGRldmljZS0+ZGV2Lm9mX25vZGUpOwo+ICAJaWYgKGRzaS0+cGFuZWwpCj4gIAkJcmV0dXJuIGRy bV9wYW5lbF9hdHRhY2goZHNpLT5wYW5lbCwgJmRzaS0+Y29ubmVjdG9yKTsKPiBAQCAtNzE2LDcg KzcxMywxMiBAQCBzdGF0aWMgdm9pZCBkd19taXBpX2RzaV92aWRlb19tb2RlX2NvbmZpZyhzdHJ1 Y3QgZHdfbWlwaV9kc2kgKmRzaSkKPiAgewo+ICAJdTMyIHZhbDsKPiAgCj4gLQl2YWwgPSBWSURf TU9ERV9UWVBFX0JVUlNUX1NZTkNfUFVMU0VTIHwgRU5BQkxFX0xPV19QT1dFUjsKPiArCXZhbCA9 IEVOQUJMRV9MT1dfUE9XRVI7Cj4gKwo+ICsJaWYgKGRzaS0+bW9kZV9mbGFncyAmIE1JUElfRFNJ X01PREVfVklERU9fQlVSU1QpCj4gKwkJdmFsIHw9IFZJRF9NT0RFX1RZUEVfQlVSU1RfU1lOQ19Q VUxTRVM7Cj4gKwllbHNlIGlmICghKGRzaS0+bW9kZV9mbGFncyAmIE1JUElfRFNJX01PREVfVklE RU9fU1lOQ19QVUxTRSkpCj4gKwkJdmFsIHw9IFZJRF9NT0RFX1RZUEVfTk9OX0JVUlNUX1NZTkNf RVZFTlRTOwo+ICAKPiAgCWRzaV93cml0ZShkc2ksIERTSV9WSURfTU9ERV9DRkcsIHZhbCk7Cj4g IH0KPiAtLSAKPiAyLjExLjAuMTk3LmdiNTU2ZGU1LmRpcnR5Cj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVsLCBTb2Z0 d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Tue, 31 Jan 2017 14:22:55 -0500 Subject: [PATCH v3 22/24] drm/rockchip: dw-mipi-dsi: support non-burst modes In-Reply-To: <20170129132444.25251-23-john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-23-john@metanate.com> Message-ID: <20170131192255.GF20076@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 29, 2017 at 01:24:42PM +0000, John Keeping wrote: Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 5bad92e2370e..58cb8ace2fe8 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -82,6 +82,7 @@ > #define FRAME_BTA_ACK BIT(14) > #define ENABLE_LOW_POWER (0x3f << 8) > #define ENABLE_LOW_POWER_MASK (0x3f << 8) > +#define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1 > #define VID_MODE_TYPE_BURST_SYNC_PULSES 0x2 > #define VID_MODE_TYPE_MASK 0x3 > > @@ -286,6 +287,7 @@ struct dw_mipi_dsi { > u32 format; > u16 input_div; > u16 feedback_div; > + unsigned long mode_flags; > > const struct dw_mipi_dsi_plat_data *pdata; > }; > @@ -551,15 +553,10 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, > return -EINVAL; > } > > - if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) || > - !(device->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) { > - dev_err(dsi->dev, "device mode is unsupported\n"); > - return -EINVAL; > - } > - > dsi->lanes = device->lanes; > dsi->channel = device->channel; > dsi->format = device->format; > + dsi->mode_flags = device->mode_flags; > dsi->panel = of_drm_find_panel(device->dev.of_node); > if (dsi->panel) > return drm_panel_attach(dsi->panel, &dsi->connector); > @@ -716,7 +713,12 @@ static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi) > { > u32 val; > > - val = VID_MODE_TYPE_BURST_SYNC_PULSES | ENABLE_LOW_POWER; > + val = ENABLE_LOW_POWER; > + > + if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) > + val |= VID_MODE_TYPE_BURST_SYNC_PULSES; > + else if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) > + val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS; > > dsi_write(dsi, DSI_VID_MODE_CFG, val); > } > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbdAaTXd (ORCPT ); Tue, 31 Jan 2017 14:23:33 -0500 Received: from mail-yb0-f180.google.com ([209.85.213.180]:33346 "EHLO mail-yb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbdAaTXA (ORCPT ); Tue, 31 Jan 2017 14:23:00 -0500 Date: Tue, 31 Jan 2017 14:22:55 -0500 From: Sean Paul To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 22/24] drm/rockchip: dw-mipi-dsi: support non-burst modes Message-ID: <20170131192255.GF20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-23-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129132444.25251-23-john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 01:24:42PM +0000, John Keeping wrote: Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 5bad92e2370e..58cb8ace2fe8 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -82,6 +82,7 @@ > #define FRAME_BTA_ACK BIT(14) > #define ENABLE_LOW_POWER (0x3f << 8) > #define ENABLE_LOW_POWER_MASK (0x3f << 8) > +#define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1 > #define VID_MODE_TYPE_BURST_SYNC_PULSES 0x2 > #define VID_MODE_TYPE_MASK 0x3 > > @@ -286,6 +287,7 @@ struct dw_mipi_dsi { > u32 format; > u16 input_div; > u16 feedback_div; > + unsigned long mode_flags; > > const struct dw_mipi_dsi_plat_data *pdata; > }; > @@ -551,15 +553,10 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, > return -EINVAL; > } > > - if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) || > - !(device->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) { > - dev_err(dsi->dev, "device mode is unsupported\n"); > - return -EINVAL; > - } > - > dsi->lanes = device->lanes; > dsi->channel = device->channel; > dsi->format = device->format; > + dsi->mode_flags = device->mode_flags; > dsi->panel = of_drm_find_panel(device->dev.of_node); > if (dsi->panel) > return drm_panel_attach(dsi->panel, &dsi->connector); > @@ -716,7 +713,12 @@ static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi) > { > u32 val; > > - val = VID_MODE_TYPE_BURST_SYNC_PULSES | ENABLE_LOW_POWER; > + val = ENABLE_LOW_POWER; > + > + if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) > + val |= VID_MODE_TYPE_BURST_SYNC_PULSES; > + else if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) > + val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS; > > dsi_write(dsi, DSI_VID_MODE_CFG, val); > } > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS