From: Nir Soffer <nirsof@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, Nir Soffer <nirsof@gmail.com>
Subject: [Qemu-devel] [PATCH v5 0/3] Fix qemu-io return value on failure
Date: Wed, 1 Feb 2017 02:31:17 +0200 [thread overview]
Message-ID: <20170201003120.23378-1-nirsof@gmail.com> (raw)
This series fix qemu-io to fail with non zero exit code when failing to open
the file.
Changes since v4:
- Added _unsupported_fmt helper
- Test any format except raw, instead of only raw
- Don't test stderr content, depends on the format
- New test move to 174 since 173 is pending
- Private copyright for new test
- Fix commit message issues
Changes since v3:
- Add cover letter
- Squash the tests fix with the behavior change, so git bisect landing on the
change in behavior does not hit unnecessarily-broken tests.
Tested by running qemu-io manually and by running tests/check-block.sh.
Note that test 059 has one unrelated test failure.
Nir Soffer (3):
qemu-io: Return non-zero exit code on failure
qemu-iotests: Add _unsupported_fmt helper
qemu-io: Add failure regression tests
qemu-io.c | 8 ++++--
tests/qemu-iotests/059.out | 3 ---
tests/qemu-iotests/070.out | 1 -
tests/qemu-iotests/075.out | 7 ------
tests/qemu-iotests/076.out | 3 ---
tests/qemu-iotests/078.out | 6 -----
tests/qemu-iotests/080.out | 18 --------------
tests/qemu-iotests/083.out | 17 -------------
tests/qemu-iotests/088.out | 6 -----
tests/qemu-iotests/092.out | 12 ---------
tests/qemu-iotests/116.out | 7 ------
tests/qemu-iotests/131.out | 1 -
tests/qemu-iotests/140.out | 1 -
tests/qemu-iotests/174 | 59 ++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/174.out | 7 ++++++
tests/qemu-iotests/common.rc | 11 +++++++++
tests/qemu-iotests/group | 1 +
17 files changed, 84 insertions(+), 84 deletions(-)
create mode 100755 tests/qemu-iotests/174
create mode 100644 tests/qemu-iotests/174.out
--
2.9.3
next reply other threads:[~2017-02-01 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 0:31 Nir Soffer [this message]
2017-02-01 0:31 ` [Qemu-devel] [PATCH v5 1/3] qemu-io: Return non-zero exit code on failure Nir Soffer
2017-02-01 0:31 ` [Qemu-devel] [PATCH v5 2/3] qemu-iotests: Add _unsupported_fmt helper Nir Soffer
2017-02-01 0:31 ` [Qemu-devel] [PATCH v5 3/3] qemu-io: Add failure regression tests Nir Soffer
2017-02-01 21:07 ` [Qemu-devel] [PATCH v5 0/3] Fix qemu-io return value on failure Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201003120.23378-1-nirsof@gmail.com \
--to=nirsof@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.