From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Feb 2017 09:07:36 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , "Martin K. Petersen" , Jens Axboe , linux-block@vger.kernel.org, linux-scsi , "linux-kernel@vger.kernel.org" , James Bottomley , Bart Van Assche , Omar Sandoval Subject: Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes Message-ID: <20170201080736.GA29170@lst.de> References: <148566590827.1627.3631056985359212959.stgit@dwillia2-desk3.amr.corp.intel.com> <20170130122452.GA9043@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Mon, Jan 30, 2017 at 01:53:36PM -0800, Dan Williams wrote: > On Mon, Jan 30, 2017 at 4:24 AM, Christoph Hellwig wrote: > > Hi Dan, > > > > this looks mostly fine to me. A few code comments below, but except > > for this there is another issue with it: We still have drivers > > that share a single request_queue for multiple gendisks, so I wonder > > scsi drivers or others? If those drivers can switch to dynamically > allocated devt (GENHD_FL_EXT_DEVT), then they don't need this fix. Mostly old floppy drivers.