From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>
Subject: Re: sort out the ->eh_timed_out mess
Date: Wed, 1 Feb 2017 10:39:01 +0100 [thread overview]
Message-ID: <20170201093901.GA1336@lst.de> (raw)
In-Reply-To: <1485794746.2712.5.camel@sandisk.com>
On Mon, Jan 30, 2017 at 04:46:00PM +0000, Bart Van Assche wrote:
> Patches 1, 2 and 4 of this series are a real improvement in my opinion.
> However, I'm not sure whether patch 3 is the best way to avoid that drivers
> have to re-override the transport template timeout handler. Have you
> considered to modify the SCSI EH such that the host timeout handler has
> priority over the transport timeout handler? I think that would result in
> a much smaller patch 3/4.
It's not too much of a difference in patch size, and I think it's
the cleaner model to only have the method once.
However if there is a consensus against this version I can respin
a patch that just changes the precendence.
next prev parent reply other threads:[~2017-02-01 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 12:18 sort out the ->eh_timed_out mess Christoph Hellwig
2017-01-30 12:18 ` [PATCH 1/4] mvumi: remove fake transport template Christoph Hellwig
2017-01-30 15:29 ` Hannes Reinecke
2017-01-30 12:18 ` [PATCH 2/4] libsas: remove sas_scsi_timed_out Christoph Hellwig
2017-01-30 15:29 ` Hannes Reinecke
2017-01-30 12:18 ` [PATCH 3/4] scsi: remove eh_timed_out methods in the transport template Christoph Hellwig
2017-01-30 15:30 ` Hannes Reinecke
2017-01-30 22:26 ` Tyrel Datwyler
2017-01-30 12:18 ` [PATCH 4/4] scsi: remove tsk_mgmt_response and it_nexus_response transport methods Christoph Hellwig
2017-01-30 15:31 ` Hannes Reinecke
2017-01-30 16:46 ` sort out the ->eh_timed_out mess Bart Van Assche
2017-02-01 9:39 ` hch [this message]
2017-02-07 0:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201093901.GA1336@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.