From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/3] sparc64: make tsb pointer computation symbolic
Date: Wed, 01 Feb 2017 16:30:18 +0000 [thread overview]
Message-ID: <20170201163018.GA27409@ravnborg.org> (raw)
In-Reply-To: <20170201123823.6273-2-bob.picco@oracle.com>
Hi Bob.
Nit pick below.
On Wed, Feb 01, 2017 at 07:38:21AM -0500, Bob Picco wrote:
> From: bob picco <bob.picco@oracle.com>
>
> Define some symbolic names for tsb/tlb miss trap tsb pointer computation.
>
> Signed-off-by: Bob Picco <bob.picco@oracle.com>
> ---
> arch/sparc/include/asm/spitfire.h | 5 +++++
> arch/sparc/kernel/sun4v_tlb_miss.S | 24 ++++++++++++------------
> 2 files changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/arch/sparc/include/asm/spitfire.h b/arch/sparc/include/asm/spitfire.h
> index 1d8321c827a8..1852a8618001 100644
> --- a/arch/sparc/include/asm/spitfire.h
> +++ b/arch/sparc/include/asm/spitfire.h
> @@ -37,6 +37,11 @@
> #define SPITFIRE_HIGHEST_LOCKED_TLBENT (64 - 1)
> #define CHEETAH_HIGHEST_LOCKED_TLBENT (16 - 1)
>
> +#define HV_TSB_SIZE_BASE 0x200 /* 512 TTE-s minimum. */
> +#define HV_TSB_SIZE_BASE_SHIFT 0x09 /* Shift of minimum tsb size. */
> +#define HV_TSB_SIZE_MASK 0x07 /* Size encoding of tsb. */
> +#define HV_TSB_TTE_SIZE_SHIFT 0x04 /* Sixteen byte tte size. */
If you end up respinning the pacthes please replace the tab after "define" with a space
Sam
next prev parent reply other threads:[~2017-02-01 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 12:38 [PATCH 1/3] sparc64: make tsb pointer computation symbolic Bob Picco
2017-02-01 16:30 ` Sam Ravnborg [this message]
2017-02-01 19:36 ` Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201163018.GA27409@ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.