From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 2/4] blk-mq-debug: Avoid that sparse complains about req_flags_t usage
Date: Wed, 1 Feb 2017 11:08:11 -0800 [thread overview]
Message-ID: <20170201190811.GB2299@vader> (raw)
In-Reply-To: <20170201182059.25601-3-bart.vanassche@sandisk.com>
On Wed, Feb 01, 2017 at 10:20:57AM -0800, Bart Van Assche wrote:
> Avoid that sparse reports the following complaints:
>
> block/elevator.c:541:29: warning: incorrect type in assignment (different base types)
> block/elevator.c:541:29: expected bool [unsigned] [usertype] next_sorted
> block/elevator.c:541:29: got restricted req_flags_t
>
> block/blk-mq-debugfs.c:92:54: warning: cast from restricted req_flags_t
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Omar Sandoval <osandov@fb.com>
> ---
> block/blk-mq-debugfs.c | 3 ++-
> block/elevator.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2017-02-01 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 18:20 [PATCH 0/4] Four patches for the blk-mq debugfs code Bart Van Assche
2017-02-01 18:20 ` [PATCH 1/4] blk-mq-debugfs: Add missing __acquires() / __releases() annotations Bart Van Assche
2017-02-01 19:07 ` Omar Sandoval
2017-02-01 18:20 ` [PATCH 2/4] blk-mq-debug: Avoid that sparse complains about req_flags_t usage Bart Van Assche
2017-02-01 19:08 ` Omar Sandoval [this message]
2017-02-01 18:20 ` [PATCH 3/4] blk-mq-debug: Make show() operations interruptible Bart Van Assche
2017-02-01 19:08 ` Omar Sandoval
2017-02-01 18:20 ` [PATCH 4/4] blk-mq-debug: Introduce debugfs_create_files() Bart Van Assche
2017-02-01 19:08 ` Omar Sandoval
2017-02-01 19:23 ` [PATCH 0/4] Four patches for the blk-mq debugfs code Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201190811.GB2299@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.