Re: [PATCH 1/2] input: touchscreen: add driver for Zeitec ZET6223

[Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Wed, Feb 01, 2017 at 11:23:31AM -0800, Dmitry Torokhov wrote:
> On Wed, Feb 01, 2017 at 11:20:53AM -0800, Dmitry Torokhov wrote:
> > On Wed, Feb 01, 2017 at 08:10:59PM +0100, Jelle van der Waa wrote:
> > > On 01/31/17 at 12:19am, Dmitry Torokhov wrote:
> > > > Hi Jelle,
> > > > 
> > > > On Wed, Jan 18, 2017 at 02:49:46PM -0800, Dmitry Torokhov wrote:
> > > > > On Wed, Jan 18, 2017 at 09:57:14PM +0100, Jelle van der Waa wrote:
> > > > > > > I also have been looking at you previosu submission and had some draft
> > > > > > > changes. I reconciled them in the patch below, if it still works for you
> > > > > > > then I'll fold everything together and apply. Please let me know.
> > > > > > 
> > > > > > I'll find some time to test the patch below, I've one small suggestion
> > > > > > to the patch below.
> > > > 
> > > > It would be very helpful if you let me know if the patch actually works
> > > > on the hardware: the merge window for 4.11 will be opening fairly soon.
> > > 
> > > Sorry, I had a busy week and at first it didn't work since I didn't have
> > > a regulator and I think the code for the regular might be wrong.
> > > 
> > > I think that you want the regulators to be optional, but
> > > devm_regulator_get_optional errors out when no vcc/vio is configured.
> > > Changing it to devm_regulator_get makes the driver work. I guess this is
> > > since devm_regulator_get_optional doesn't allow the creation of a dummy
> > > device while devm_regulator_get does.
> > 
> > Ah, yes, these should have been non-optional. I'll fix it up and apply
> > then.
> 
> Hmm.. but no, we only acess regulators if they are non-NULL in
> zet6223_power_on(). I used devm_regulator_get_optional() to avoid
> needless sleep in zet6223_power_on() when we do not have regulators
> defined. Let me look some more...

What is the error you are getting from devm_regulator_get_optional()?
What kind of system is that? Do you have system with full constraints?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html