From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZE1A-0000la-1C for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:49:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZE16-0007BM-Bn for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:49:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZE16-0007BI-5O for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:49:24 -0500 Date: Thu, 2 Feb 2017 09:49:18 +0000 From: "Daniel P. Berrange" Message-ID: <20170202094918.GB2915@redhat.com> Reply-To: "Daniel P. Berrange" References: <1485954928-22287-1-git-send-email-den@openvz.org> <20170201135306.GI3232@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Denis V. Lunev" , qemu-devel@nongnu.org, Anton Nefedov On Wed, Feb 01, 2017 at 04:54:28PM -0800, Paolo Bonzini wrote: > > > On 01/02/2017 05:53, Daniel P. Berrange wrote: > >> > >> + if (ret < 0 && errno == EPIPE) { > > IMHO you should just remove "&& errno == EPIPE" and it'd be fine. > > It should be errno != EAGAIN. Oh, yes, thats right. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|