From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34016 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdBBK6y (ORCPT ); Thu, 2 Feb 2017 05:58:54 -0500 Date: Thu, 2 Feb 2017 11:58:53 +0100 From: Greg Kroah-Hartman To: Omar Sandoval Cc: Jens Axboe , linux-block@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace Message-ID: <20170202105853.GA27128@kroah.com> References: <20170201081608.GB18278@kroah.com> <20170201083115.GA16278@vader> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170201083115.GA16278@vader> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed, Feb 01, 2017 at 12:31:15AM -0800, Omar Sandoval wrote: > On Wed, Feb 01, 2017 at 09:16:08AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 31, 2017 at 02:53:16PM -0800, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > When I moved the blk-mq debugging information to debugfs, I didn't > > > realize that blktrace also created directories in debugfs that > > > conflicted with the blk-mq directories. This series fixes that. > > > > > > Patch 1 adds a new debugfs helper needed for patch 6. Greg, could I get > > > an ack on that if it makes sense? Jens and I went back and forth on this > > > for a little while, but patch 6 has more of the rationale on why we > > > decided that this approach was the cleanest. > > > > I can't find patch 6, you only cc:ed me on the first patch :( > > > > Care to bounce them all to me? > > > > thanks, > > > > greg k-h > > Gah, I forgot --cc-cover to git-send-email. The series is all here: > http://marc.info/?l=linux-block&r=1&b=201701&w=2. I can also send the > patches directly to you if you prefer that. I don't understand the problem here. How do you not know if you have created the debugfs file or not? You have the structure, with the correct name, how could it have been created? Can't you save the dentry to the debugfs file in the structure that has the name? thanks, greg k-h