From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbdBBPzb (ORCPT ); Thu, 2 Feb 2017 10:55:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:37453 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbdBBPyD (ORCPT ); Thu, 2 Feb 2017 10:54:03 -0500 Date: Thu, 2 Feb 2017 16:52:52 +0100 From: Petr Mladek To: Sergey Senozhatsky Cc: Steven Rostedt , Sergey Senozhatsky , Andrew Morton , Linus Torvalds , Jan Kara , Tejun Heo , Calvin Owens , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter Hurley , linux-kernel@vger.kernel.org Subject: Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines Message-ID: <20170202155252.GG23754@pathway.suse.cz> References: <20161227141611.940-1-sergey.senozhatsky@gmail.com> <20161227141611.940-5-sergey.senozhatsky@gmail.com> <20170201110648.33651ee8@gandalf.local.home> <20170202060538.GA419@jagdpanzerIV.localdomain> <20170202153753.GF23754@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170202153753.GF23754@pathway.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2017-02-02 16:37:53, Petr Mladek wrote: > On Thu 2017-02-02 15:05:38, Sergey Senozhatsky wrote: > > On (02/01/17 11:06), Steven Rostedt wrote: > > [..] > > > > static void printk_safe_flush_line(const char *text, int len) > > > > { > > > > /* > > > > - * The buffers are flushed in NMI only on panic. The messages must > > > > - * go only into the ring buffer at this stage. Consoles will get > > > > - * explicitly called later when a crashdump is not generated. > > > > + * Avoid any console drivers calls from here, because we may be > > > > + * in NMI or printk_safe context (when in panic). The messages > > > > + * must go only into the ring buffer at this stage. Consoles will > > > > + * get explicitly called later when a crashdump is not generated. > > > > */ > > > > - if (in_nmi()) > > > > - printk_deferred("%.*s", len, text); > > > > - else > > > > - printk("%.*s", len, text); > > > > + printk_deferred("%.*s", len, text); > > > > } > > > > > > The helper function was there because of the if statement. Just nuke > > > this function and call printk_deferred() directly. You can move the > > > comment to the caller. > > > > indeed. thanks. > > > > Petr, how would you prefer to handle this? > > I am still learning how to manage the patches in the printk.git tree. > > I would like to add Steven's Reviewed-by tags, links to the mails, > and list of CC-ed people. IMHO, the only way is to rebase the for-4.11 > and for-next branches. Then I could do the above suggested change during > the rebase. Alternatively you could send this other solution as a replay to this thread. Then we could comment, add reviewed tags. And I could use the new approved variant during the rebase. This is probably better approach for non-oneliner changes. > Any other solutions are welcome. I will wait with the rebase at least > until Monday. We are discussing the lockdep in the 6th patch anyway. Best Regards, Petr