From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@fb.com>
Cc: Omar Sandoval <osandov@osandov.com>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace
Date: Thu, 2 Feb 2017 18:18:15 +0100 [thread overview]
Message-ID: <20170202171815.GA31948@kroah.com> (raw)
In-Reply-To: <6f6a76f1-7c43-4674-941e-ed3fc5379402@fb.com>
On Thu, Feb 02, 2017 at 08:17:31AM -0700, Jens Axboe wrote:
> On 02/02/2017 03:58 AM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 01, 2017 at 12:31:15AM -0800, Omar Sandoval wrote:
> >> On Wed, Feb 01, 2017 at 09:16:08AM +0100, Greg Kroah-Hartman wrote:
> >>> On Tue, Jan 31, 2017 at 02:53:16PM -0800, Omar Sandoval wrote:
> >>>> From: Omar Sandoval <osandov@fb.com>
> >>>>
> >>>> When I moved the blk-mq debugging information to debugfs, I didn't
> >>>> realize that blktrace also created directories in debugfs that
> >>>> conflicted with the blk-mq directories. This series fixes that.
> >>>>
> >>>> Patch 1 adds a new debugfs helper needed for patch 6. Greg, could I get
> >>>> an ack on that if it makes sense? Jens and I went back and forth on this
> >>>> for a little while, but patch 6 has more of the rationale on why we
> >>>> decided that this approach was the cleanest.
> >>>
> >>> I can't find patch 6, you only cc:ed me on the first patch :(
> >>>
> >>> Care to bounce them all to me?
> >>>
> >>> thanks,
> >>>
> >>> greg k-h
> >>
> >> Gah, I forgot --cc-cover to git-send-email. The series is all here:
> >> http://marc.info/?l=linux-block&r=1&b=201701&w=2. I can also send the
> >> patches directly to you if you prefer that.
> >
> > I don't understand the problem here. How do you not know if you have
> > created the debugfs file or not? You have the structure, with the
> > correct name, how could it have been created? Can't you save the dentry
> > to the debugfs file in the structure that has the name?
>
> The problem is that blktrace registers a trace name directory, which
> can be either whole device or partition, depending on what you trace.
> For the blk-mq debug parts, we always just register the whole device
> name. There's no way to save the partition dentry, and imho, why even
> would you when you can just look it up. It's a file system...
I agree, it is a file system, but usually that debugfs file is
associated with some sort of data you want to keep track of outside of a
filesystem :)
Anyway, if it's such a big pain, then it's fine, add the function, no
objection from me anymore.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-02-02 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 22:53 [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace Omar Sandoval
2017-01-31 22:53 ` [PATCH 1/6] debugfs: add debugfs_lookup() Omar Sandoval
2017-01-31 22:53 ` [PATCH 2/6] block: fix debugfs config conditional in struct request_queue Omar Sandoval
2017-01-31 22:53 ` [PATCH 3/6] blktrace: make do_blk_trace_setup() static Omar Sandoval
2017-01-31 22:53 ` [PATCH 4/6] block: use same block debugfs directory for blk-mq and blktrace Omar Sandoval
2017-01-31 22:53 ` [PATCH 5/6] blk-mq: move debugfs_remove() of disk dir to blk_release_queue() Omar Sandoval
2017-01-31 22:53 ` [PATCH 6/6] blktrace: use existing disk debugfs directory Omar Sandoval
2017-02-01 8:16 ` [PATCH 0/6] block: fix blk-mq debugfs vs. blktrace Greg Kroah-Hartman
2017-02-01 8:31 ` Omar Sandoval
2017-02-02 10:58 ` Greg Kroah-Hartman
2017-02-02 15:17 ` Jens Axboe
2017-02-02 17:18 ` Greg Kroah-Hartman [this message]
2017-02-02 17:01 ` Omar Sandoval
2017-02-02 17:18 ` Greg Kroah-Hartman
2017-02-02 17:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202171815.GA31948@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.