From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.77.65 with SMTP id a62csp540775lfb; Fri, 3 Feb 2017 02:14:13 -0800 (PST) X-Received: by 10.200.55.178 with SMTP id d47mr13121210qtc.60.1486116852962; Fri, 03 Feb 2017 02:14:12 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 12si18935227qkv.211.2017.02.03.02.14.12 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 03 Feb 2017 02:14:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:33065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZase-0007Rp-AZ for alex.bennee@linaro.org; Fri, 03 Feb 2017 05:14:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZaal-0000TS-Ak for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:55:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZaak-0006SI-H1 for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:55:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZaae-0006Nb-Um; Fri, 03 Feb 2017 04:55:37 -0500 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4ECC7E9D2; Fri, 3 Feb 2017 09:55:36 +0000 (UTC) Received: from pxdev.xzpeter.org (ovpn-8-19.pek2.redhat.com [10.72.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AB20243361; Fri, 3 Feb 2017 09:55:32 +0000 (UTC) Date: Fri, 3 Feb 2017 17:55:29 +0800 From: Peter Xu To: Auger Eric Message-ID: <20170203095529.GR5151@pxdev.xzpeter.org> References: <1485422381-29019-1-git-send-email-eric.auger@redhat.com> <1485422381-29019-5-git-send-email-eric.auger@redhat.com> <20170126100643.GD2083@work-vm> <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 03 Feb 2017 09:55:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, vijay.kilari@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, shannon.zhao@linaro.org, Vijaya.Kumar@cavium.com, christoffer.dall@linaro.org, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: LywGJ/yXbexo On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: [...] > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > >> index 1a22887..ebd755c 100644 > >> --- a/include/migration/vmstate.h > >> +++ b/include/migration/vmstate.h > >> @@ -188,6 +188,8 @@ enum VMStateFlags { > >> > >> typedef enum { > >> MIG_PRI_DEFAULT = 0, > >> + MIG_PRI_GICV3_ITS, > >> + MIG_PRI_GICV3, > >> MIG_PRI_MAX, > > > > Can we keep this commented so it's trivially easy to see the order, something like: > > > > typedef enum { > > MIG_PRI_DEFAULT = 0, > > + MIG_PRI_GICV3_ITS, /* Needs to be before PCI devices */ > > + MIG_PRI_GICV3, /* Must be before ITS */ > Sure > > Thanks! Besides above: is it possible that in the future other platforms (rather than ARM) can leverage these new introduced priority? If so, would it be nicer that we use general names (like, e.g., INTCxxx? or better?) rather than platform-specific names (like, GICxxx)? Thanks, -- peterx From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZaal-0000TS-Ak for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:55:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZaak-0006SI-H1 for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:55:43 -0500 Date: Fri, 3 Feb 2017 17:55:29 +0800 From: Peter Xu Message-ID: <20170203095529.GR5151@pxdev.xzpeter.org> References: <1485422381-29019-1-git-send-email-eric.auger@redhat.com> <1485422381-29019-5-git-send-email-eric.auger@redhat.com> <20170126100643.GD2083@work-vm> <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> Subject: Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Auger Eric Cc: "Dr. David Alan Gilbert" , eric.auger.pro@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, shannon.zhao@linaro.org, christoffer.dall@linaro.org, drjones@redhat.com, vijay.kilari@gmail.com, Vijaya.Kumar@cavium.com, quintela@redhat.com On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: [...] > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > >> index 1a22887..ebd755c 100644 > >> --- a/include/migration/vmstate.h > >> +++ b/include/migration/vmstate.h > >> @@ -188,6 +188,8 @@ enum VMStateFlags { > >> > >> typedef enum { > >> MIG_PRI_DEFAULT = 0, > >> + MIG_PRI_GICV3_ITS, > >> + MIG_PRI_GICV3, > >> MIG_PRI_MAX, > > > > Can we keep this commented so it's trivially easy to see the order, something like: > > > > typedef enum { > > MIG_PRI_DEFAULT = 0, > > + MIG_PRI_GICV3_ITS, /* Needs to be before PCI devices */ > > + MIG_PRI_GICV3, /* Must be before ITS */ > Sure > > Thanks! Besides above: is it possible that in the future other platforms (rather than ARM) can leverage these new introduced priority? If so, would it be nicer that we use general names (like, e.g., INTCxxx? or better?) rather than platform-specific names (like, GICxxx)? Thanks, -- peterx