From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.77.65 with SMTP id a62csp541225lfb; Fri, 3 Feb 2017 02:15:36 -0800 (PST) X-Received: by 10.200.37.199 with SMTP id f7mr12661546qtf.186.1486116936280; Fri, 03 Feb 2017 02:15:36 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m17si18992948qtf.24.2017.02.03.02.15.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 03 Feb 2017 02:15:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:33072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZatz-0000Nd-Gn for alex.bennee@linaro.org; Fri, 03 Feb 2017 05:15:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZacQ-0002Ig-2y for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:57:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZacP-0007ma-DS for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:57:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38892) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZacB-0007Xx-7D; Fri, 03 Feb 2017 04:57:20 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31DDE61B83; Fri, 3 Feb 2017 09:57:11 +0000 (UTC) Received: from work-vm (ovpn-117-144.ams2.redhat.com [10.36.117.144]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v139v6Zr025192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Feb 2017 04:57:08 -0500 Date: Fri, 3 Feb 2017 09:57:05 +0000 From: "Dr. David Alan Gilbert" To: Peter Xu Message-ID: <20170203095704.GA3208@work-vm> References: <1485422381-29019-1-git-send-email-eric.auger@redhat.com> <1485422381-29019-5-git-send-email-eric.auger@redhat.com> <20170126100643.GD2083@work-vm> <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> <20170203095529.GR5151@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203095529.GR5151@pxdev.xzpeter.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 03 Feb 2017 09:57:11 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, vijay.kilari@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, Vijaya.Kumar@cavium.com, Auger Eric , qemu-arm@nongnu.org, shannon.zhao@linaro.org, christoffer.dall@linaro.org, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: sYPuYEo0fNRd * Peter Xu (peterx@redhat.com) wrote: > On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: > > [...] > > > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > > >> index 1a22887..ebd755c 100644 > > >> --- a/include/migration/vmstate.h > > >> +++ b/include/migration/vmstate.h > > >> @@ -188,6 +188,8 @@ enum VMStateFlags { > > >> > > >> typedef enum { > > >> MIG_PRI_DEFAULT = 0, > > >> + MIG_PRI_GICV3_ITS, > > >> + MIG_PRI_GICV3, > > >> MIG_PRI_MAX, > > > > > > Can we keep this commented so it's trivially easy to see the order, something like: > > > > > > typedef enum { > > > MIG_PRI_DEFAULT = 0, > > > + MIG_PRI_GICV3_ITS, /* Needs to be before PCI devices */ > > > + MIG_PRI_GICV3, /* Must be before ITS */ > > Sure > > > > Thanks! > > Besides above: is it possible that in the future other platforms > (rather than ARM) can leverage these new introduced priority? If so, > would it be nicer that we use general names (like, e.g., INTCxxx? or > better?) rather than platform-specific names (like, GICxxx)? Yes, but the ordering rules on other platforms might be subtly different. Dave > Thanks, > > -- peterx -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZacQ-0002Ig-2y for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:57:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZacP-0007ma-DS for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:57:26 -0500 Date: Fri, 3 Feb 2017 09:57:05 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20170203095704.GA3208@work-vm> References: <1485422381-29019-1-git-send-email-eric.auger@redhat.com> <1485422381-29019-5-git-send-email-eric.auger@redhat.com> <20170126100643.GD2083@work-vm> <9bd0a672-d27c-f232-6ba0-67ad5c1e6f23@redhat.com> <20170203095529.GR5151@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203095529.GR5151@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Auger Eric , eric.auger.pro@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, shannon.zhao@linaro.org, christoffer.dall@linaro.org, drjones@redhat.com, vijay.kilari@gmail.com, Vijaya.Kumar@cavium.com, quintela@redhat.com * Peter Xu (peterx@redhat.com) wrote: > On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote: > > [...] > > > >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > > >> index 1a22887..ebd755c 100644 > > >> --- a/include/migration/vmstate.h > > >> +++ b/include/migration/vmstate.h > > >> @@ -188,6 +188,8 @@ enum VMStateFlags { > > >> > > >> typedef enum { > > >> MIG_PRI_DEFAULT = 0, > > >> + MIG_PRI_GICV3_ITS, > > >> + MIG_PRI_GICV3, > > >> MIG_PRI_MAX, > > > > > > Can we keep this commented so it's trivially easy to see the order, something like: > > > > > > typedef enum { > > > MIG_PRI_DEFAULT = 0, > > > + MIG_PRI_GICV3_ITS, /* Needs to be before PCI devices */ > > > + MIG_PRI_GICV3, /* Must be before ITS */ > > Sure > > > > Thanks! > > Besides above: is it possible that in the future other platforms > (rather than ARM) can leverage these new introduced priority? If so, > would it be nicer that we use general names (like, e.g., INTCxxx? or > better?) rather than platform-specific names (like, GICxxx)? Yes, but the ordering rules on other platforms might be subtly different. Dave > Thanks, > > -- peterx -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK