From: Pascal Mazon <pascal.mazon@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 4/5] net/tap: fix up log message to correct channel
Date: Fri, 3 Feb 2017 10:45:32 +0100 [thread overview]
Message-ID: <20170203104532.756aa998@paques.dev.6wind.com> (raw)
In-Reply-To: <20170202223330.39240-4-keith.wiles@intel.com>
On Thu, 2 Feb 2017 16:33:29 -0600
Keith Wiles <keith.wiles@intel.com> wrote:
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 39 +++++++++++++++++++--------------------
> 1 file changed, 19 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 6673182..4f7eacf 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -167,7 +167,7 @@ tun_alloc(char *name, uint16_t qid)
>
> /* Set the TUN/TAP configuration and get the name if needed
> */ if (ioctl(fd, TUNSETIFF, (void *)&ifr) < 0) {
> - RTE_LOG(ERR, PMD, "Unable to set TUNSETIFF for %s\n",
> + RTE_LOG(WARNING, PMD, "Unable to set TUNSETIFF for
> %s\n", ifr.ifr_name);
> perror("TUNSETIFF");
> goto error;
> @@ -206,7 +206,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts) /* allocate the next mbuf */
> mbuf = rte_pktmbuf_alloc(rxq->mp);
> if (unlikely(!mbuf)) {
> - RTE_LOG(WARNING, PMD, "Unable to allocate mbuf\n");
> + RTE_LOG(WARNING, PMD, "TAP unable to allocate
> mbuf\n"); break;
> }
>
> @@ -559,8 +559,8 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> int fd;
>
> if ((rx_queue_id >= internals->nb_queues) || !mp) {
> - RTE_LOG(ERR, PMD, "nb_queues %d mp %p\n",
> - internals->nb_queues, mp);
> + RTE_LOG(WARNING, PMD, "nb_queues %d too small or mempool
> NULL\n",
> + internals->nb_queues);
> return -1;
> }
>
> @@ -572,7 +572,7 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> RTE_PKTMBUF_HEADROOM);
>
> if (buf_size < ETH_FRAME_LEN) {
> - RTE_LOG(ERR, PMD,
> + RTE_LOG(WARNING, PMD,
> "%s: %d bytes will not fit in mbuf (%d bytes)\n",
> dev->data->name, ETH_FRAME_LEN, buf_size);
> return -ENOMEM;
> @@ -582,7 +582,7 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> if (fd == -1)
> return -1;
>
> - RTE_LOG(INFO, PMD, "RX TAP device name %s, qid %d on fd %d\n",
> + RTE_LOG(DEBUG, PMD, " RX TAP device name %s, qid %d on fd %d\n",
> internals->name, rx_queue_id,
> internals->rxq[rx_queue_id].fd);
> return 0;
> @@ -605,7 +605,7 @@ tap_tx_queue_setup(struct rte_eth_dev *dev,
> if (ret == -1)
> return -1;
>
> - RTE_LOG(INFO, PMD, "TX TAP device name %s, qid %d on fd %d\n",
> + RTE_LOG(DEBUG, PMD, " TX TAP device name %s, qid %d on fd %d\n",
> internals->name, tx_queue_id,
> internals->txq[tx_queue_id].fd);
> return 0;
> @@ -643,7 +643,7 @@ pmd_mac_address(int fd, struct rte_eth_dev *dev, struct
> ether_addr *addr) memset(&ifr, 0, sizeof(ifr));
>
> if (ioctl(fd, SIOCGIFHWADDR, &ifr) == -1) {
> - RTE_LOG(ERR, PMD, "ioctl failed (SIOCGIFHWADDR) (%s)\n",
> + RTE_LOG(WARNING, PMD, "ioctl failed (SIOCGIFHWADDR) (%s)\n",
> ifr.ifr_name);
> return -1;
> }
> @@ -662,26 +662,25 @@ eth_dev_tap_create(const char *name, char *tap_name)
> struct rte_eth_dev_data *data = NULL;
> int i, fd = -1;
>
> - RTE_LOG(INFO, PMD,
> - "%s: Create TAP Ethernet device with %d queues on numa %u\n",
> - name, RTE_PMD_TAP_MAX_QUEUES, rte_socket_id());
> + RTE_LOG(DEBUG, PMD, " TAP device with %d queues on numa %u\n",
> + RTE_PMD_TAP_MAX_QUEUES, rte_socket_id());
>
> data = rte_zmalloc_socket(tap_name, sizeof(*data), 0, numa_node);
> if (!data) {
> - RTE_LOG(ERR, PMD, "Failed to allocate data\n");
> + RTE_LOG(ERR, PMD, "TAP Failed to allocate data\n");
> goto error_exit;
> }
>
> pmd = rte_zmalloc_socket(tap_name, sizeof(*pmd), 0, numa_node);
> if (!pmd) {
> - RTE_LOG(ERR, PMD, "Unable to allocate internal struct\n");
> + RTE_LOG(ERR, PMD, "TAP Unable to allocate internal
> struct\n"); goto error_exit;
> }
>
> /* Use the name and not the tap_name */
> dev = rte_eth_dev_allocate(tap_name);
> if (!dev) {
> - RTE_LOG(ERR, PMD, "Unable to allocate device struct\n");
> + RTE_LOG(ERR, PMD, "TAP Unable to allocate device struct\n");
> goto error_exit;
> }
>
> @@ -712,7 +711,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
> /* Create the first Tap device */
> fd = tun_alloc(tap_name, 0);
> if (fd < 0) {
> - RTE_LOG(ERR, PMD, "tun_alloc() failed\n");
> + RTE_LOG(ERR, PMD, "TAP tun_alloc() failed for %s\n",
> tap_name); goto error_exit;
> }
>
> @@ -734,7 +733,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
> return 0;
>
> error_exit:
> - RTE_PMD_DEBUG_TRACE("Unable to initialize %s\n", name);
> + RTE_LOG(DEBUG, PMD, "TAP Unable to initialize %s\n", name);
>
> if (fd > 0)
> close(fd);
> @@ -787,7 +786,7 @@ rte_pmd_tap_probe(const char *name, const char *params)
> DEFAULT_TAP_NAME, tap_unit++);
>
> if (params && (params[0] != '\0')) {
> - RTE_LOG(INFO, PMD, "paramaters (%s)\n", params);
> + RTE_LOG(DEBUG, PMD, "paramaters (%s)\n", params);
>
> kvlist = rte_kvargs_parse(params, valid_arguments);
> if (kvlist) {
> @@ -812,14 +811,14 @@ rte_pmd_tap_probe(const char *name, const char *params)
> }
> pmd_link.link_speed = speed;
>
> - RTE_LOG(INFO, PMD, "Initializing pmd_tap for %s as %s\n",
> + RTE_LOG(NOTICE, PMD, "Initializing pmd_tap for %s as %s\n",
> name, tap_name);
>
> ret = eth_dev_tap_create(name, tap_name);
>
> leave:
> if (ret == -1) {
> - RTE_LOG(INFO, PMD, "Failed to create pmd for %s as %s\n",
> + RTE_LOG(ERR, PMD, "Failed to create pmd for %s as %s\n",
> name, tap_name);
> tap_unit--; /* Restore the unit number */
> }
> @@ -837,7 +836,7 @@ rte_pmd_tap_remove(const char *name)
> struct pmd_internals *internals;
> int i;
>
> - RTE_LOG(INFO, PMD, "Closing TUN/TAP Ethernet device on numa %u\n",
> + RTE_LOG(DEBUG, PMD, "Closing TUN/TAP Ethernet device on numa %u\n",
> rte_socket_id());
>
> /* find the ethdev entry */
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
next prev parent reply other threads:[~2017-02-03 9:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 22:33 [PATCH 1/5] nic/tap: fix tap docs for device name Keith Wiles
2017-02-02 22:33 ` [PATCH 2/5] net/tap: fix multi-queue support Keith Wiles
2017-02-03 9:37 ` Pascal Mazon
2017-02-03 20:32 ` Wiles, Keith
2017-02-02 22:33 ` [PATCH 3/5] net/tap: remove redundant fds array Keith Wiles
2017-02-03 9:38 ` Pascal Mazon
2017-02-02 22:33 ` [PATCH 4/5] net/tap: fix up log message to correct channel Keith Wiles
2017-02-03 9:45 ` Pascal Mazon [this message]
2017-02-02 22:33 ` [PATCH 5/5] net/tap: remove unused variable and minor cleanup Keith Wiles
2017-02-03 9:47 ` Pascal Mazon
2017-02-03 9:32 ` [PATCH 1/5] nic/tap: fix tap docs for device name Pascal Mazon
2017-02-03 11:48 ` Ferruh Yigit
2017-02-05 16:05 ` [PATCH v2 1/6] net/tap: " Keith Wiles
2017-02-05 16:05 ` [PATCH v2 2/6] net/tap: remove redundant fds array Keith Wiles
2017-02-05 16:05 ` [PATCH v2 3/6] net/tap: remove unused variable and minor cleanup Keith Wiles
2017-02-05 16:05 ` [PATCH v2 4/6] net/tap: fix multi-queue support Keith Wiles
2017-02-06 15:45 ` Pascal Mazon
2017-02-06 15:57 ` Wiles, Keith
2017-02-05 16:05 ` [PATCH v2 5/6] net/tap: cleanup log messages Keith Wiles
2017-02-05 16:05 ` [PATCH v2 6/6] net/tap: link set down must be before close Keith Wiles
2017-02-06 15:57 ` Pascal Mazon
2017-02-06 16:03 ` Wiles, Keith
2017-02-06 19:40 ` [PATCH v3 1/7] net/tap: fix tap docs for device name Keith Wiles
2017-02-06 19:40 ` [PATCH v3 2/7] net/tap: remove redundant fds array Keith Wiles
2017-02-06 19:40 ` [PATCH v3 3/7] net/tap: remove unused variable and minor cleanup Keith Wiles
2017-02-06 19:40 ` [PATCH v3 4/7] net/tap: fix multi-queue support Keith Wiles
2017-02-06 19:40 ` [PATCH v3 5/7] net/tap: cleanup log messages Keith Wiles
2017-02-06 19:40 ` [PATCH v3 6/7] net/tap: link set down must be done before close Keith Wiles
2017-02-06 19:40 ` [PATCH v3 7/7] net/tap: move closing fds to pmd close from pmd stop Keith Wiles
2017-02-07 8:51 ` Pascal Mazon
2017-02-07 14:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203104532.756aa998@paques.dev.6wind.com \
--to=pascal.mazon@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.