From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbdBCKro (ORCPT ); Fri, 3 Feb 2017 05:47:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60790 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002AbdBCKrn (ORCPT ); Fri, 3 Feb 2017 05:47:43 -0500 Date: Fri, 3 Feb 2017 11:47:40 +0100 From: Pavel Machek To: "Andrejczuk, Grzegorz" Cc: Thomas Gleixner , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "bp@suse.de" , "dave.hansen@linux.intel.com" , "Daniluk, Lukasz" , "Cownie, James H" , "Pan, Jacob jun" , "Luc, Piotr" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Message-ID: <20170203104740.GA30941@amd> References: <1477576923-3244-1-git-send-email-grzegorz.andrejczuk@intel.com> <1477576923-3244-3-git-send-email-grzegorz.andrejczuk@intel.com> <20161126131542.GB20568@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2016-12-09 12:49:33, Andrejczuk, Grzegorz wrote: > > > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote: > > > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote: > > > > > +#ifdef CONFIG_X86_64 > > > > > +static int phi_r3mwait_disabled __read_mostly; > > > > > + > > > > > +static int __init phir3mwait_disable(char *__unused) { > > > > > + phi_r3mwait_disabled =3D 1; > > > > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi"); > > > >=20 > > > > Why would that be a warning? The sysadmin added the command line=20 > > > > switch, so why does he needs to be warned? > > >=20 > > > Its telling admin he did not make a typo on the command line. We ofte= n do that.... > > > > Definitely not at the warning level. >=20 > Is info level OK for that message? I'd say so. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliUX8wACgkQMOfwapXb+vI8UgCdE3lZlQ6TjnFJqrTi+dgC3Fxc NP0AnAvo7+kVBXakA3cUaoBqDsElAprq =jEMO -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--