All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Masanari Iida <standby24x7@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include file
Date: Fri, 3 Feb 2017 13:43:17 +0100	[thread overview]
Message-ID: <20170203124317.GD12545@localhost> (raw)
In-Reply-To: <20170201110507.11042-1-standby24x7@gmail.com>

On Wed, Feb 01, 2017 at 08:05:07PM +0900, Masanari Iida wrote:
> This patch removed duplicated include line.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/staging/greybus/authentication.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
> index 168626ba0c03..6c5dcb1c226b 100644
> --- a/drivers/staging/greybus/authentication.c
> +++ b/drivers/staging/greybus/authentication.c
> @@ -16,7 +16,6 @@
>  
>  #include "greybus_authentication.h"
>  #include "firmware.h"
> -#include "greybus.h"

Please remove the other "greybus.h" include that precedes the "system"
includes instead.

>  
>  #define CAP_TIMEOUT_MS		1000

Also add a component prefix to your subject (i.e. "staging: greybus:
authentication: remove...").

Thanks,
Johan

      reply	other threads:[~2017-02-03 12:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 11:05 [PATCH] [linux-next] staging: greybus: Remove duplicate include file Masanari Iida
2017-02-03 12:43 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170203124317.GD12545@localhost \
    --to=johan@kernel.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=standby24x7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.