From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v5 3/4] device property: export code duplicating array of property entries
Date: Fri, 3 Feb 2017 07:15:52 -0800 [thread overview]
Message-ID: <20170203151552.GC3868@dtor-ws> (raw)
In-Reply-To: <1486122330.2133.374.camel@linux.intel.com>
On Fri, Feb 03, 2017 at 01:45:30PM +0200, Andy Shevchenko wrote:
> On Thu, 2017-02-02 at 17:41 -0800, Dmitry Torokhov wrote:
> > When augmenting ACPI-enumerated devices with additional property data
> > based
> > on DMI info, a module has often several potential property sets, with
> > only
> > one being active on a given box. In order to save memory it should be
> > possible to mark everything and __initdata or __initconst, execute DMI
> > match early, and duplicate relevant properties. Then kernel will
> > discard
> > the rest of them.
> >
>
> Here you again rewrote the code you rewrote in previous patch.
> Please, remove those hunks in previous patch and rebase this one on top
> of the result.
I do no see the point really. If I am not exposing the new APIs then
there is no point in touching the code. If I am creating new API then I
do not want to go through contortion of producing something similar to
the old code flow just to "fix" it in the subsequent patch.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-02-03 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 1:41 [PATCH v5 0/4] Export APIs to copy device properties & more Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 1/4] device property: allow to constify properties Dmitry Torokhov
2017-02-03 11:40 ` Andy Shevchenko
2017-02-03 15:09 ` Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 2/4] device property: constify property arrays values Dmitry Torokhov
2017-02-03 11:43 ` Andy Shevchenko
2017-02-03 15:12 ` Dmitry Torokhov
2017-02-03 1:41 ` [PATCH v5 3/4] device property: export code duplicating array of property entries Dmitry Torokhov
2017-02-03 11:45 ` Andy Shevchenko
2017-02-03 15:15 ` Dmitry Torokhov [this message]
2017-02-03 1:41 ` [PATCH v5 4/4] i2c: allow specify device properties in i2c_board_info Dmitry Torokhov
2017-02-03 11:46 ` Andy Shevchenko
2017-02-07 12:44 ` Rafael J. Wysocki
2017-02-07 13:25 ` Wolfram Sang
2017-02-09 13:52 ` [PATCH v5 0/4] Export APIs to copy device properties & more Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203151552.GC3868@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.