From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 13/13] drm/i915/dp: use readb and writeb
 calls for single byte DPCD access
Date: Fri, 3 Feb 2017 19:25:09 +0200
Message-ID: <20170203172509.GM31595@intel.com>
References: <cover.1486131408.git.jani.nikula@intel.com>
 <9119e131d4c03190b6686b6ceeb0495933cd7355.1486131408.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D905B6EBBA
 for <intel-gfx@lists.freedesktop.org>; Fri,  3 Feb 2017 17:25:13 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <9119e131d4c03190b6686b6ceeb0495933cd7355.1486131408.git.jani.nikula@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dhinakaran.pandiyan@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBGZWIgMDMsIDIwMTcgYXQgMDQ6MTk6MzZQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gVGhpcyBpcyB3aGF0IHdlIGhhdmUgdGhlIHJlYWRiIGFuZCB3cml0ZWIgdmFyaWFudHMg
Zm9yLiBEbyBzb21lIG1pbm9yCj4gcmV0dXJuIHZhbHVlIGFuZCB2YXJpYWJsZSBjbGVhbnVwIHdo
aWxlIGF0IGl0Lgo+IAo+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwu
Y29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t
Pgo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4g
LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAzNyArKysrKysrKysrKysr
KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25z
KCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA5
MGFlOTVmMmVjYjIuLmZkZDRhYmZjMjM4MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+
IEBAIC0zNjc3LDkgKzM2NzcsOSBAQCBpbnRlbF9lZHBfaW5pdF9kcGNkKHN0cnVjdCBpbnRlbF9k
cCAqaW50ZWxfZHApCj4gIAkJdWludDhfdCBmcmFtZV9zeW5jX2NhcDsKPiAgCj4gIAkJZGV2X3By
aXYtPnBzci5zaW5rX3N1cHBvcnQgPSB0cnVlOwo+IC0JCWRybV9kcF9kcGNkX3JlYWQoJmludGVs
X2RwLT5hdXgsCj4gLQkJCQkgRFBfU0lOS19ERVZJQ0VfQVVYX0ZSQU1FX1NZTkNfQ0FQLAo+IC0J
CQkJICZmcmFtZV9zeW5jX2NhcCwgMSk7Cj4gKwkJZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2Rw
LT5hdXgsCj4gKwkJCQkgIERQX1NJTktfREVWSUNFX0FVWF9GUkFNRV9TWU5DX0NBUCwKPiArCQkJ
CSAgJmZyYW1lX3N5bmNfY2FwKTsKPiAgCQlkZXZfcHJpdi0+cHNyLmF1eF9mcmFtZV9zeW5jID0g
ZnJhbWVfc3luY19jYXAgPyB0cnVlIDogZmFsc2U7Cj4gIAkJLyogUFNSMiBuZWVkcyBmcmFtZSBz
eW5jIGFzIHdlbGwgKi8KPiAgCQlkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCA9IGRldl9wcml2
LT5wc3IuYXV4X2ZyYW1lX3N5bmM7Cj4gQEAgLTM3NDksOCArMzc0OSw4IEBAIGludGVsX2RwX2dl
dF9kcGNkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlpbnRlbF9kcF9zZXRfc2lua19y
YXRlcyhpbnRlbF9kcCk7Cj4gIAlpbnRlbF9kcF9zZXRfY29tbW9uX3JhdGVzKGludGVsX2RwKTsK
PiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfU0lOS19DT1VO
VCwKPiAtCQkJICAgICAmaW50ZWxfZHAtPnNpbmtfY291bnQsIDEpIDwgMCkKPiArCWlmIChkcm1f
ZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfU0lOS19DT1VOVCwKPiArCQkJICAgICAg
JmludGVsX2RwLT5zaW5rX2NvdW50KSA8PSAwKQoKQXMgYW4gYWRkaXRpb25hbCBjaGFuZ2UgaXQg
d291bGQgYmUgbmljZSB0byBoYXZlIGEgbG9jYWwgdmFyaWFibGUKZm9yIHRoaXMgc2luY2Ugd2Un
bGwgZG8gJy0+c2lua19jb3VudCA9IC0+c2lua19jb3VudCAmIFNPTUVUSElORycgCmZ1cnRoZXIg
ZG93bi4gSU1PIGl0J3Mgc29tZXdoYXQgY29uZnVzaW5nIHRvIGZpcnN0IHJlYWQgdGhlIHVubWFz
a2VkCnZhbHVlZGlyZWN0bHkgaW50byB0aGUgZmluYWwgbG9jYXRpb24gYW5kIHRoZW4gbWFzayBp
biBwbGFjZS4KCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAgCS8qCj4gQEAgLTM3ODcsNyArMzc4
Nyw3IEBAIGludGVsX2RwX2dldF9kcGNkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHN0
YXRpYyBib29sCj4gIGludGVsX2RwX2Nhbl9tc3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkK
PiAgewo+IC0JdTggYnVmWzFdOwo+ICsJdTggbXN0bV9jYXA7Cj4gIAo+ICAJaWYgKCFpOTE1LmVu
YWJsZV9kcF9tc3QpCj4gIAkJcmV0dXJuIGZhbHNlOwo+IEBAIC0zNzk4LDEwICszNzk4LDEwIEBA
IGludGVsX2RwX2Nhbl9tc3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWlmIChpbnRl
bF9kcC0+ZHBjZFtEUF9EUENEX1JFVl0gPCAweDEyKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4g
LQlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfTVNUTV9DQVAsIGJ1Ziwg
MSkgIT0gMSkKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfTVNU
TV9DQVAsICZtc3RtX2NhcCkgIT0gMSkKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAo+IC0JcmV0dXJu
IGJ1ZlswXSAmIERQX01TVF9DQVA7Cj4gKwlyZXR1cm4gbXN0bV9jYXAgJiBEUF9NU1RfQ0FQOwo+
ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZAo+IEBAIC0zOTQ3LDkgKzM5NDcsOCBAQCBpbnQgaW50ZWxf
ZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykKPiAgc3RhdGlj
IGJvb2wKPiAgaW50ZWxfZHBfZ2V0X3NpbmtfaXJxKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs
IHU4ICpzaW5rX2lycV92ZWN0b3IpCj4gIHsKPiAtCXJldHVybiBkcm1fZHBfZHBjZF9yZWFkKCZp
bnRlbF9kcC0+YXV4LAo+IC0JCQkJICAgICAgIERQX0RFVklDRV9TRVJWSUNFX0lSUV9WRUNUT1Is
Cj4gLQkJCQkgICAgICAgc2lua19pcnFfdmVjdG9yLCAxKSA9PSAxOwo+ICsJcmV0dXJuIGRybV9k
cF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9ERVZJQ0VfU0VSVklDRV9JUlFfVkVDVE9S
LAo+ICsJCQkJIHNpbmtfaXJxX3ZlY3RvcikgPT0gMTsKPiAgfQo+ICAKPiAgc3RhdGljIGJvb2wK
PiBAQCAtNDAxMiwxMyArNDAxMSwxMyBAQCBzdGF0aWMgdWludDhfdCBpbnRlbF9kcF9hdXRvdGVz
dF9saW5rX3RyYWluaW5nKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHN0YXRpYyB1aW50
OF90IGludGVsX2RwX2F1dG90ZXN0X3ZpZGVvX3BhdHRlcm4oc3RydWN0IGludGVsX2RwICppbnRl
bF9kcCkKPiAgewo+ICAJdWludDhfdCB0ZXN0X3BhdHRlcm47Cj4gLQl1aW50MTZfdCB0ZXN0X21p
c2M7Cj4gKwl1aW50OF90IHRlc3RfbWlzYzsKPiAgCV9fYmUxNiBoX3dpZHRoLCB2X2hlaWdodDsK
PiAgCWludCBzdGF0dXMgPSAwOwo+ICAKPiAgCS8qIFJlYWQgdGhlIFRFU1RfUEFUVEVSTiAoRFAg
Q1RTIDMuMS41KSAqLwo+IC0Jc3RhdHVzID0gZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1
eCwgRFBfVEVTVF9QQVRURVJOLAo+IC0JCQkJICAmdGVzdF9wYXR0ZXJuLCAxKTsKPiArCXN0YXR1
cyA9IGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1BBVFRFUk4sCj4g
KwkJCQkgICAmdGVzdF9wYXR0ZXJuKTsKPiAgCWlmIChzdGF0dXMgPD0gMCkgewo+ICAJCURSTV9E
RUJVR19LTVMoIlRlc3QgcGF0dGVybiByZWFkIGZhaWxlZFxuIik7Cj4gIAkJcmV0dXJuIERQX1RF
U1RfTkFLOwo+IEBAIC00MDQwLDggKzQwMzksOCBAQCBzdGF0aWMgdWludDhfdCBpbnRlbF9kcF9h
dXRvdGVzdF92aWRlb19wYXR0ZXJuKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkJcmV0
dXJuIERQX1RFU1RfTkFLOwo+ICAJfQo+ICAKPiAtCXN0YXR1cyA9IGRybV9kcF9kcGNkX3JlYWQo
JmludGVsX2RwLT5hdXgsIERQX1RFU1RfTUlTQzAsCj4gLQkJCQkgICZ0ZXN0X21pc2MsIDEpOwo+
ICsJc3RhdHVzID0gZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfTUlT
QzAsCj4gKwkJCQkgICAmdGVzdF9taXNjKTsKPiAgCWlmIChzdGF0dXMgPD0gMCkgewo+ICAJCURS
TV9ERUJVR19LTVMoIlRFU1QgTUlTQyByZWFkIGZhaWxlZFxuIik7Cj4gIAkJcmV0dXJuIERQX1RF
U1RfTkFLOwo+IEBAIC00MTAwLDEwICs0MDk5LDggQEAgc3RhdGljIHVpbnQ4X3QgaW50ZWxfZHBf
YXV0b3Rlc3RfZWRpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJCSAqLwo+ICAJCWJs
b2NrICs9IGludGVsX2Nvbm5lY3Rvci0+ZGV0ZWN0X2VkaWQtPmV4dGVuc2lvbnM7Cj4gIAo+IC0J
CWlmICghZHJtX2RwX2RwY2Rfd3JpdGUoJmludGVsX2RwLT5hdXgsCj4gLQkJCQkJRFBfVEVTVF9F
RElEX0NIRUNLU1VNLAo+IC0JCQkJCSZibG9jay0+Y2hlY2tzdW0sCj4gLQkJCQkJMSkpCj4gKwkJ
aWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9FRElEX0NIRUNL
U1VNLAo+ICsJCQkJICAgICAgIGJsb2NrLT5jaGVja3N1bSkgPD0gMCkKPiAgCQkJRFJNX0RFQlVH
X0tNUygiRmFpbGVkIHRvIHdyaXRlIEVESUQgY2hlY2tzdW1cbiIpOwo+ICAKPiAgCQl0ZXN0X3Jl
c3VsdCA9IERQX1RFU1RfQUNLIHwgRFBfVEVTVF9FRElEX0NIRUNLU1VNX1dSSVRFOwo+IC0tIAo+
IDIuMS40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs
LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK