From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbdBDEbr (ORCPT ); Fri, 3 Feb 2017 23:31:47 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:60209 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbdBDEbq (ORCPT ); Fri, 3 Feb 2017 23:31:46 -0500 Date: Fri, 3 Feb 2017 20:31:39 -0800 From: Guenter Roeck To: Derek Robson Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: Drivers: staging: speakup: spk_priv.h - style fix Message-ID: <20170204043139.GA2260@roeck-us.net> References: <20170203235641.10306-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203235641.10306-1-robsonde@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote: > Changed function definition argument to have identifier name. > found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/speakup/spk_priv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h > index 98c4b6f0344a..1952d7887b3b 100644 > --- a/drivers/staging/speakup/spk_priv.h > +++ b/drivers/staging/speakup/spk_priv.h > @@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth); > int spk_synth_is_alive_nop(struct spk_synth *synth); > int spk_synth_is_alive_restart(struct spk_synth *synth); > void synth_printf(const char *buf, ...); > -int synth_request_region(u_long, u_long); > -int synth_release_region(u_long, u_long); > +int synth_request_region(unsigned long start, unsigned long n) > +int synth_release_region(unsigned long start, unsigned long n) Hmmm .. you didn't compile test your code, did you ? You asked why 0day reports an error. If you compile this code, I am quite sure that you are going to see the same errors. Guenter > int synth_add(struct spk_synth *in_synth); > void synth_remove(struct spk_synth *in_synth); >