From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
cphealy@gmail.com
Subject: Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier
Date: Sat, 4 Feb 2017 18:55:17 +0100 [thread overview]
Message-ID: <20170204175517.GC8364@lunn.ch> (raw)
In-Reply-To: <20170203182021.14246-7-vivien.didelot@savoirfairelinux.com>
> +#define DSA_NOTIFIER_BRIDGE_JOIN 1
> +#define DSA_NOTIFIER_BRIDGE_LEAVE 2
Hi Vivien
Is one notifier per event sufficient?
I've not looked at what actually needs to happen when a port joins a
bridge, in a D in DSA setup. Do we need to both enable the flow of
frames around the switch fabric, but also block those frames going out
ports they should not? Do we need a first notifier to put in place
the blocks, and then a second notifier to enable the flow of packets?
What we don't want is a window of time during the fabric setup as a
whole is inconsistent, and frames a leaking out ports they should not.
Andrew
next prev parent reply other threads:[~2017-02-04 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 18:20 [PATCH net-next 0/6] net: dsa: add fabric notifier Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 1/6] net: dsa: move netdevice notifier registration Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 2/6] net: dsa: simplify netdevice events handling Vivien Didelot
2017-02-04 2:43 ` Florian Fainelli
2017-02-04 16:13 ` Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 3/6] net: dsa: rollback bridging on error Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 4/6] net: dsa: change state setter scope Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 5/6] net: dsa: add switch notifier Vivien Didelot
2017-02-03 18:20 ` [PATCH net-next 6/6] net: dsa: introduce bridge notifier Vivien Didelot
2017-02-04 17:55 ` Andrew Lunn [this message]
2017-02-04 18:26 ` Vivien Didelot
2017-02-04 18:30 ` Andrew Lunn
2017-02-06 21:56 ` [PATCH net-next 0/6] net: dsa: add fabric notifier David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204175517.GC8364@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.