Re: [PATCH -next] ACPI/IORT: Fix the error return code in iort_add_smmu_platform_device()

[Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>]

On Sun, Feb 05, 2017 at 03:45:59PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> The error return code PTR_ERR(pdev) is always 0 since pdev is
> equal to 0 in this error handling case.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/acpi/arm64/iort.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It has been reported twice already:

https://patchwork.kernel.org/patch/9521003/

Rafael, do you expect me to send you a pull request with IORT fixes ?

I can't see Dan's patch in linux-acpi patchwork anymore, and there
is another fix pending:

https://patchwork.kernel.org/patch/9507041/

Please let me know how you want to handle them.

Thanks !
Lorenzo

> 
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index e0d2e6e..655407a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
>  
>  	pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
>  	if (!pdev)
> -		return PTR_ERR(pdev);
> +		return -ENOMEM;
>  
>  	count = ops->iommu_count_resources(node);