All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: Missing XSM permission for livepatch sysctl
Date: Mon, 6 Feb 2017 14:53:58 +0000	[thread overview]
Message-ID: <20170206145358.vff2ov7ctkf5snuz@citrix.com> (raw)
In-Reply-To: <20170206145032.GF19124@char.us.oracle.com>

On Mon, Feb 06, 2017 at 09:50:32AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 06, 2017 at 12:53:56PM +0000, Wei Liu wrote:
> > On Mon, Feb 06, 2017 at 12:51:45PM +0000, Wei Liu wrote:
> > > When running XTF with a XSM-enabled Xen (generated by one of my osstest
> > > flight for testing something else).
> > > 
> > > Executing 'xl create -F
> > > tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
> > > --- Xen Test Framework ---
> > > Environment: HVM 32bit (No paging)
> > > Live Patch Privilege Check
> > > Fail: test_upload: Unexpected return code -13
> > > Fail: test_list: Unexpected return code -13
> > > Fail: test_get: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Test result: FAILURE
> > > 
> > > -13 is EACCESS.
> > > 
> > > Should be easy to fix.
> > 
> > But but but there is already livepatch_op in dom0.te, so I'm baffled.
> 
>  43     if ( op->interface_version != XEN_SYSCTL_INTERFACE_VERSION )                
>  44         return -EACCES;                 
> 
> in do_sysctl
> 

They are supposed to be the same version. I didn't modify Xen source
code at all and the test box was freshly installed. The non-XSM build
passed.

Wei.


> 
> > 
> > Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-06 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 12:51 Missing XSM permission for livepatch sysctl Wei Liu
2017-02-06 12:53 ` Wei Liu
2017-02-06 14:50   ` Konrad Rzeszutek Wilk
2017-02-06 14:53     ` Wei Liu [this message]
2017-02-06 15:05       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206145358.vff2ov7ctkf5snuz@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.