All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ondrej Kozina <okozina@redhat.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>
Subject: Re: [git pull] device mapper fixes for 4.10-rc7
Date: Mon, 6 Feb 2017 15:48:31 -0500	[thread overview]
Message-ID: <20170206204831.GA24338@redhat.com> (raw)
In-Reply-To: <CA+55aFytrfm+kGWNPdg4PYHtZhx4kVn+EJDcLMskRhVwemzROw@mail.gmail.com>

On Fri, Feb 03 2017 at  7:18pm -0500,
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Fri, Feb 3, 2017 at 11:11 AM, Mike Snitzer <snitzer@redhat.com> wrote:
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-4.10-fixes
> 
> Hmm.
> 
>    "fatal: Couldn't find remote ref dm-4.10-fixes"
> 
> Forgot to push?  And why didn't git pull-request warn about it? Have
> you cooked up your own broken script for this?

I did forget to push, sorry about that, now pushed.

As for why git-request-pull didn't warn.  I used this commandline:
git request-pull v4.10-rc6 git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git dm-4.10-fixes | tee dm-4.10-fixes-pull.txt

I just did a test with a local dm-4.10-test tag that I didn't push and
sure enough I _do_ get a warning.  But that warning went to stderr and
I just missed it.  I'll improve my workflow to check the error code of
the git-request-pull first. And then re-run to output to a text file.

> There is a "dm-4.10" branch with that commit, but iirc you usually
> have signed tags so I suspect it really is a missed push, not a wrong
> name.

Right, just missed the push, I always do signed tags.

Thanks,
Mike

      reply	other threads:[~2017-02-06 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 19:11 [git pull] device mapper fixes for 4.10-rc7 Mike Snitzer
2017-02-04  0:18 ` Linus Torvalds
2017-02-06 20:48   ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206204831.GA24338@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=okozina@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.