All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>, netdev@vger.kernel.org
Subject: Re: "TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised." message with "ethtool -K eth0 gro off"
Date: Mon, 6 Feb 2017 19:12:26 -0200	[thread overview]
Message-ID: <20170206211226.GC3413@localhost.localdomain> (raw)
In-Reply-To: <1486133253.21871.89.camel@edumazet-glaptop3.roam.corp.google.com>

On Fri, Feb 03, 2017 at 06:47:33AM -0800, Eric Dumazet wrote:
> On Fri, 2017-02-03 at 12:28 -0200, Marcelo Ricardo Leitner wrote:
> 
> > Aren't you mixing the endpoints here? MSS is the largest amount of data
> > that the peer can receive in a single segment, and not how much it will
> > send. For the sending part, that depends on what the other peer
> > announced, and we can have 2 different MSS in a single connection, one
> > for each peer.
> > 
> > If a peer later wants to send larger segments, it can, but it must
> > respect the mss advertised by the other peer during handshake.
> > 
> 
> I am not mixing endpoints, you are.
> 
> If you need to be convinced, please grab :
> https://patchwork.ozlabs.org/patch/723028/
> 
> And just watch "ss -temoi ..." 

I still don't get it, but I also hit the warning on my laptop, using
iwlwifi. Not sure what I did in order to trigger it, it was by accident.

  Marcelo

  reply	other threads:[~2017-02-06 21:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 11:52 "TCP: eth0: Driver has suspect GRO implementation, TCP performance may be compromised." message with "ethtool -K eth0 gro off" Markus Trippelsdorf
2017-02-02 12:32 ` Eric Dumazet
2017-02-02 12:34   ` Markus Trippelsdorf
2017-02-02 13:31     ` Eric Dumazet
2017-02-02 13:59       ` Eric Dumazet
2017-02-03 11:54         ` Marcelo Ricardo Leitner
2017-02-03 12:06           ` Markus Trippelsdorf
2017-02-03 13:24           ` Eric Dumazet
2017-02-03 13:53             ` Marcelo Ricardo Leitner
2017-02-03 14:16               ` Eric Dumazet
2017-02-03 14:28                 ` Marcelo Ricardo Leitner
2017-02-03 14:47                   ` Eric Dumazet
2017-02-06 21:12                     ` Marcelo Ricardo Leitner [this message]
2017-03-10 12:22                       ` Markus Trippelsdorf
2017-03-19 12:14                       ` Markus Trippelsdorf
2017-03-19 19:20                         ` Eric Dumazet
2017-03-20 19:27                           ` Marcelo Ricardo Leitner
2017-03-22 13:47                             ` Eric Dumazet
2017-03-24 15:56                               ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206211226.GC3413@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=markus@trippelsdorf.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.