Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

[Greg Kurz <groug@kaod.org>]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Mon, 6 Feb 2017 13:36:43 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote:
> > This patchset adds the throttle support for the 9p-local driver.
> > For now this functionality can be enabled only through qemu cli options.
> > QMP interface and support to other drivers need further extensions.  
> 
> This part is a bit scary - if 2.9 is released with just the cli option
> and not the QMP interface, then how does someone like libvirt introspect
> whether the feature is available for use?
> 

I'm not aware of anything related to fsdev in QMP... and libvirt seems to
only parse the output of -help to guess fsdev capabilities. And indeed,
qemu-options.hx doesn't expose this new feature.

> Please make sure we don't reach 2.9 with only a half-baked feature;
> whether that means finishing the QMP work or temporarily disabling the
> cli additions until a later release can finish the work.
> 

Would this be ok to add the missing bits in qemu-options.hx or do you
expect more ?

Cheers.

--
Greg

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]