From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs Date: Tue, 7 Feb 2017 12:04:12 +0100 Message-ID: <20170207110412.GD29507@ulmo.ba.sec> References: <1486458995-31018-1-git-send-email-shawnguo@kernel.org> <1486458995-31018-2-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0294418217==" Return-path: Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EC436E671 for ; Tue, 7 Feb 2017 11:04:16 +0000 (UTC) Received: by mail-wr0-x241.google.com with SMTP id 89so5318872wrr.1 for ; Tue, 07 Feb 2017 03:04:16 -0800 (PST) In-Reply-To: <1486458995-31018-2-git-send-email-shawnguo@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , Laurent Pinchart , Daniel Vetter , Marek Vasut , Alexey Brodkin , Russell King , Xinliang Liu , Tomi Valkeinen , Mali DP Maintainers , Ben Skeggs , Jyri Sarha , dri-devel@lists.freedesktop.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org --===============0294418217== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DiL7RhKs8rK9YGuF" Content-Disposition: inline --DiL7RhKs8rK9YGuF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2017 at 05:16:13PM +0800, Shawn Guo wrote: > From: Shawn Guo >=20 > The vblank is mostly CRTC specific and implemented as part of CRTC > driver. Let's keep the vblank hooks struct drm_driver for legacy > drivers, and add corresponding hooks in struct drm_crtc_funcs. These > hooks take struct drm_crtc pointer as argument, and will be called by > core vblank handling code for DRIVER_MODESET drivers. >=20 > The new hooks get plugged into core by adding wrapper functions for > vblank handling code. The .get_vblank_counter hook is effectively > optional, as we provide drm_vblank_no_hw_counter() as the default > fallback in the wrapper function. >=20 > Signed-off-by: Shawn Guo > --- > drivers/gpu/drm/drm_irq.c | 53 +++++++++++++++++++++++++++++++++++++++++= ------ > include/drm/drm_crtc.h | 44 +++++++++++++++++++++++++++++++++++++++ > include/drm/drm_drv.h | 9 ++++++++ > 3 files changed, 100 insertions(+), 6 deletions(-) I had been meaning to do this for a long time myself but never got around to it. Great stuff. Acked-by: Thierry Reding --DiL7RhKs8rK9YGuF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliZqawACgkQ3SOs138+ s6G1KQ//d3Ci2I36e7z6/TcLcWH+J/1wA+mZUgWknJbVHaVxjjxP4IpBY03OA1cq QHgbm0mmkhzs0/JyDDMOMGmK6mVdSOYRWNphkRqOvl7cQP5vEVDIfZUZaBv53i1m sJL2xCQvTPUrSKP/cbRdnpwaYEKJm1Dhg9cNCsi+dAFN8osyfK2nAIpfKi6hU+tf nC0+pCDSaKTLxuNTx+HDaSmhz9yLjyRYNS5zEq0rig6YZnwHT6zA4FKEk5SxAeBE V8LMkbXTQ2Vsrx5o0wrtVnRgnVcNqoVvCyCB+A+Pl05lqkqJTz33M45u8xrl7/ZN iwyNTMMLPzRMZkogoWKI3rB02IqFznIAnjAi80tjFscV4Yp8YYFkd0nMh32S/nf1 aajHkDlb5R1iAViWNHz9bvYrWbgcxcCln3rRdbOggR3uPxGZMbuUiiykkA7URNNA OxkgZSXrywjxJ/en/2QnH0+WyxIc/WOqAUI7IE46FUi+GJTMNC4eMEZt9CnWJaHW TtRfequSF4VvIVZpv0RaZpgONS6Txz8BD84r/p1GCLZppGEvbrw8Z1iLJKQk7M2g Cim+BwZmvpkjV1eOc6/AmVfGf9BlrqkSmqWxY3Njdi7diaJHWlCRPIEJOt4Ux6Lo cnwXH6LCwuAREwmIVuYV8ppEjZmfWo7xs8rxpvl+fhqWBQN/GNg= =frBN -----END PGP SIGNATURE----- --DiL7RhKs8rK9YGuF-- --===============0294418217== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0294418217==--