From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs Date: Tue, 7 Feb 2017 12:50:06 +0100 Message-ID: <20170207115006.GI29507@ulmo.ba.sec> References: <1486458995-31018-1-git-send-email-shawnguo@kernel.org> <1486458995-31018-2-git-send-email-shawnguo@kernel.org> <20170207105206.bnqtojosyu6d5bzk@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1833474826==" Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52AA56E68B for ; Tue, 7 Feb 2017 11:50:09 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id c85so27827076wmi.1 for ; Tue, 07 Feb 2017 03:50:09 -0800 (PST) In-Reply-To: <20170207105206.bnqtojosyu6d5bzk@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Marek Vasut , Neil Armstrong , Daniel Vetter , Alexey Brodkin , Liviu Dudau , Russell King , dri-devel@lists.freedesktop.org, Xinliang Liu , Tomi Valkeinen , Mali DP Maintainers , Jyri Sarha , Daniel Vetter , Maxime Ripard , Ben Skeggs , Shawn Guo , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============1833474826== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CD/aTaZybdUisKIc" Content-Disposition: inline --CD/aTaZybdUisKIc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2017 at 11:52:06AM +0100, Daniel Vetter wrote: > On Tue, Feb 07, 2017 at 11:38:08AM +0100, Andrzej Hajda wrote: > > On 07.02.2017 10:16, Shawn Guo wrote: > > > +static u32 __get_vblank_counter(struct drm_device *dev, unsigned int= pipe) > > > +{ > > > + if (drm_core_check_feature(dev, DRIVER_MODESET)) { > > > + struct drm_crtc *crtc =3D drm_crtc_from_index(dev, pipe); > > > + > > > + if (crtc->funcs->get_vblank_counter) > > > + return crtc->funcs->get_vblank_counter(crtc); > > > + } > > > + > > > + if (dev->driver->get_vblank_counter) > > > + return dev->driver->get_vblank_counter(dev, pipe); > >=20 > > After converting all modeset drivers dev->driver->get_vblank_counter > > could be called only for non-modeset drivers, ie 'else' can be put > > before last if, the same for two other callbacks. >=20 > Shawn converted a lot of drivers, but not yet all of them. There's a lot > more kms drivers, so probably will take some time until we can do this. > But a good long-term goal indeed. Probably should be added to that new TODO list thing... =3D) Thierry --CD/aTaZybdUisKIc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliZtG0ACgkQ3SOs138+ s6EmHA/7Bhp8k2qzRcrqX1N5ylo2GS3lCTtBnGi+WZcBvf+8w5POmWlxWwlaJseT blA2Fdgxo5BXGUSJP3pjMK8NJWlsH5I9qCGUNalS+NIlZq+D5VVXmoTgFP5lU/BH ktKK9ef+wqUTL5/qHOP2KAwvH27cuLpeRQVQb7zLsN+11GHzpYr5uMd46wVX1Yst RHW5PM2uuPmUy1mKNRwsaAyeEqbTOT+W3g9KtG+JGzFurYEEutfjKWeWlHOZAbEq k/CICK4fE4BlhhX5T++cK3X+Ww+uiyMWfVeS+wrz4Ke3sjW68r8eCXTfEemXoLQl ssI+BecIZ8HA1Bl2jgUydgaJtW2HTYeytxBwYEWvG8wPk68vV6Ti6NNLQ6qHeTiJ IejTcy78gAydX8TAu/U7iequDPKMMSDzVQsX1FgTgPXDGwvM8TrHQ40ERaVXvN3T PWNMJfMomcAg0dwh20Ex1/D2XyPXJgB7BEMYhZYnmu48Pfaw9hFbqN+EEcfU4h41 NS81jypMfDhmx5IpJMJbWW/kE5OCisQd4qoHkfJ8LgWg/aoGNPrOw/+LSl74fg3+ Po6/WkHP3Gh/NRwgqKBX1/cugOt+mIciUs1A6/oJw31tZcVZNl0nqU8pnwW7NW1r iW5boEXUcIhXayI+sn/SoyiKvAUleE7lgKyvitXI9rBQ7yIsWGE= =i8pK -----END PGP SIGNATURE----- --CD/aTaZybdUisKIc-- --===============1833474826== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1833474826==--