From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts: add script to test a package
Date: Tue, 7 Feb 2017 15:46:25 +0100 [thread overview]
Message-ID: <20170207144625.GE3578@free.fr> (raw)
In-Reply-To: <87zihyqd0o.fsf@dell.be.48ers.dk>
Peter, All,
On 2017-02-07 15:41 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > Luca, All,
> > On 2017-02-06 21:40 +0100, Luca Ceresoli spake thusly:
> >> On 06/02/2017 19:02, Yann E. MORIN wrote:
> > [--SNIP--]
> >> > + printf ", olddefconfig"
> >> > + if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> >> > + printf ": FAILED\n"
> >> > + return
> >> > + fi
> >> > + while read line; do
> >> > + if ! grep "^${line}\$" "${dir}/.config" >/dev/null 2>&1; then
> >>
> >> I suggest removing the redirects and using 'grep -q' here.
>
> > grep -q is not POSIX. ;-)
>
> But is that a real concern?
No, of course it is not. But I prefer not having non-portable stuff when
the portable solution is pretty easy and straightforward... Personal
preference...
Regards,
Yann E. MORIN.
> We do use grep -q quite a bit already
> (including in dependencies.sh):
>
> git grep 'grep -q' | wc -l
> 46
>
> --
> Bye, Peter Korsgaard
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-02-07 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 18:02 [Buildroot] [PATCH] support/scripts: add script to test a package Yann E. MORIN
2017-02-06 20:40 ` Luca Ceresoli
2017-02-06 20:43 ` Thomas Petazzoni
2017-02-06 20:59 ` Luca Ceresoli
2017-02-07 9:33 ` Yann E. MORIN
2017-02-07 10:48 ` Luca Ceresoli
2017-02-07 14:41 ` Peter Korsgaard
2017-02-07 14:46 ` Yann E. MORIN [this message]
2017-02-06 20:44 ` Thomas De Schampheleire
2017-02-07 9:52 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207144625.GE3578@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.