From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 07 Feb 2017 14:53:07 +0000 Subject: [patch v2] drm/i915/gvt/kvmgt: remove some dead code Message-Id: <20170207145307.GA28648@mwanda> List-Id: References: <1486478097.3121.120.camel@linux.intel.com> In-Reply-To: <1486478097.3121.120.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zhenyu Wang , Jike Song Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , intel-gvt-dev@lists.freedesktop.org "caps.buf" is always NULL here and "caps.size" is always zero. The code is a no-op and can be removed. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index 3f656e3a6e5a..773a45aa18f8 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c @@ -965,11 +965,6 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd, sparse->areas[0].offset PAGE_ALIGN(vgpu_aperture_offset(vgpu)); sparse->areas[0].size = vgpu_aperture_sz(vgpu); - if (!caps.buf) { - kfree(caps.buf); - caps.buf = NULL; - caps.size = 0; - } break; case VFIO_PCI_BAR3_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch v2] drm/i915/gvt/kvmgt: remove some dead code Date: Tue, 7 Feb 2017 17:53:07 +0300 Message-ID: <20170207145307.GA28648@mwanda> References: <1486478097.3121.120.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1486478097.3121.120.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Zhenyu Wang , Jike Song Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , intel-gvt-dev@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ImNhcHMuYnVmIiBpcyBhbHdheXMgTlVMTCBoZXJlIGFuZCAiY2Fwcy5zaXplIiBpcyBhbHdheXMg emVyby4gIFRoZSBjb2RlCmlzIGEgbm8tb3AgYW5kIGNhbiBiZSByZW1vdmVkLgoKU2lnbmVkLW9m Zi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9rdm1ndC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3Z0L2t2bWd0LmMKaW5kZXggM2Y2NTZlM2E2ZTVhLi43NzNhNDVhYTE4ZjggMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9rdm1ndC5jCisrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2d2dC9rdm1ndC5jCkBAIC05NjUsMTEgKzk2NSw2IEBAIHN0YXRpYyBsb25nIGludGVs X3ZncHVfaW9jdGwoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1bnNpZ25lZCBpbnQgY21kLAog CQkJc3BhcnNlLT5hcmVhc1swXS5vZmZzZXQgPQogCQkJCQlQQUdFX0FMSUdOKHZncHVfYXBlcnR1 cmVfb2Zmc2V0KHZncHUpKTsKIAkJCXNwYXJzZS0+YXJlYXNbMF0uc2l6ZSA9IHZncHVfYXBlcnR1 cmVfc3oodmdwdSk7Ci0JCQlpZiAoIWNhcHMuYnVmKSB7Ci0JCQkJa2ZyZWUoY2Fwcy5idWYpOwot CQkJCWNhcHMuYnVmID0gTlVMTDsKLQkJCQljYXBzLnNpemUgPSAwOwotCQkJfQogCQkJYnJlYWs7 CiAKIAkJY2FzZSBWRklPX1BDSV9CQVIzX1JFR0lPTl9JTkRFWCAuLi4gVkZJT19QQ0lfQkFSNV9S RUdJT05fSU5ERVg6Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=