From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbdBHHjc (ORCPT ); Wed, 8 Feb 2017 02:39:32 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:42765 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753601AbdBHHjb (ORCPT ); Wed, 8 Feb 2017 02:39:31 -0500 Date: Wed, 8 Feb 2017 09:13:24 +0300 From: Dan Carpenter To: Carlos Palminha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v2] staging: rtl8712: rtl8712: fix sparse warnings Message-ID: <20170208061148.GH11154@mwanda> References: <20170208012315.4164-1-palminha@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208012315.4164-1-palminha@synopsys.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 01:23:15AM +0000, Carlos Palminha wrote: > Fixed sparse warnings > * No need to convert from le32, pointers for structure with same endianness (cast from restricted __le32) > * Need to convert bitwise operation for le32 structure (invalid assignment from int to __le32) > > Signed-off-by: Carlos Palminha > --- > Changes v1->v2: > * Clarify patch description to ensure confidence > > drivers/staging/rtl8712/rtl8712_xmit.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c > index c4f03a602a2e..67713643c923 100644 > --- a/drivers/staging/rtl8712/rtl8712_xmit.c > +++ b/drivers/staging/rtl8712/rtl8712_xmit.c > @@ -561,19 +561,19 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz) > > ptxdesc_mp = &txdesc_mp; > /* offset 8 */ > - ptxdesc->txdw2 = cpu_to_le32(ptxdesc_mp->txdw2); > + ptxdesc->txdw2 = ptxdesc_mp->txdw2; Nah... The original is done deliberately. When I'm reviewing this patch I can see that now. Just leave this as-is. regards, dan carpenter