From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754504AbdBHNJZ (ORCPT ); Wed, 8 Feb 2017 08:09:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754587AbdBHNIy (ORCPT ); Wed, 8 Feb 2017 08:08:54 -0500 Date: Wed, 8 Feb 2017 13:57:26 +0100 From: Jiri Olsa To: Hari Bathini Cc: ast@fb.com, peterz@infradead.org, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com Subject: Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info Message-ID: <20170208125726.GB22166@krava> References: <148654265580.27983.8822211570127163843.stgit@hbathini.in.ibm.com> <148654270963.27983.11333098688761605858.stgit@hbathini.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148654270963.27983.11333098688761605858.stgit@hbathini.in.ibm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 08 Feb 2017 12:57:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 02:01:49PM +0530, Hari Bathini wrote: SNIP > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index ffac8ca..1946a17 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -875,6 +875,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) > signal(SIGTERM, sig_handler); > signal(SIGSEGV, sigsegv_handler); > > + if (rec->opts.record_namespaces) > + tool->namespace_events = true; should we do this by default? seems like low traffic event with info that should be always present also in case we keep the --namespace option, please add it to the record's doc jirka