From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v4 1/7] ether: add function to query for link state interrupt Date: Wed, 8 Feb 2017 15:25:08 -0800 Message-ID: <20170208152508.13fc0878@xeon-e3> References: <1429637564-5656-1-git-send-email-stephen@networkplumber.org> <1429637564-5656-2-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "alexmay@microsoft.com" , Stephen Hemminger To: Thomas Monjalon Return-path: Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 7AC9698 for ; Thu, 9 Feb 2017 00:25:17 +0100 (CET) Received: by mail-pf0-f181.google.com with SMTP id e4so44828841pfg.1 for ; Wed, 08 Feb 2017 15:25:17 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 8 Jul 2015 23:42:05 +0000 Thomas Monjalon wrote: > 2015-04-21 10:32, Stephen Hemminger: > > Allow application to query whether link state will work. > > This is also part of abstracting dependency on PCI. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_ether/rte_ethdev.c | 14 ++++++++++++++ > > lib/librte_ether/rte_ethdev.h | 12 ++++++++++++ > [...] > > /** > > + * Test whether device supports link state interrupt mode. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @return > > + * - (1) if link state interrupt is supported > > + * - (0) if link state interrupt is not supported > > + */ > > +extern int > > +rte_eth_has_link_state(uint8_t port_id); > > It requires change in map file to work with shared library. A better way to solve this to move drv_flags out of PCI driver and into generic driver data structure.