All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Senna Tschudin <peter.senna@collabora.com>
To: Romain Perier <romain.perier@collabora.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	jeffrey.t.kirsher@intel.com,
	"David S. Miller" <davem@davemloft.net>,
	stas.yakovlev@gmail.com,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Peter Senna Tschudin <peter.senna@collabora.co.uk>
Subject: Re: [RFC 14/19] scsi: pmcraid: Replace PCI pool old API
Date: Wed, 8 Feb 2017 19:42:35 +0100	[thread overview]
Message-ID: <20170208184235.GN16878@collabora.com> (raw)
In-Reply-To: <20170208163457.28853-15-romain.perier@collabora.com>

On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
> 
Tested by compilation only.

Acked-by: Peter Senna Tschudin <peter.senna@collabora.com>
Tested-by: Peter Senna Tschudin <peter.senna@collabora.com>
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
>  drivers/scsi/pmcraid.c | 10 +++++-----
>  drivers/scsi/pmcraid.h |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 49e70a3..0f893c4 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4699,13 +4699,13 @@ pmcraid_release_control_blocks(
>  		return;
>  
>  	for (i = 0; i < max_index; i++) {
> -		pci_pool_free(pinstance->control_pool,
> +		dma_pool_free(pinstance->control_pool,
>  			      pinstance->cmd_list[i]->ioa_cb,
>  			      pinstance->cmd_list[i]->ioa_cb_bus_addr);
>  		pinstance->cmd_list[i]->ioa_cb = NULL;
>  		pinstance->cmd_list[i]->ioa_cb_bus_addr = 0;
>  	}
> -	pci_pool_destroy(pinstance->control_pool);
> +	dma_pool_destroy(pinstance->control_pool);
>  	pinstance->control_pool = NULL;
>  }
>  
> @@ -4762,8 +4762,8 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
>  		pinstance->host->unique_id);
>  
>  	pinstance->control_pool =
> -		pci_pool_create(pinstance->ctl_pool_name,
> -				pinstance->pdev,
> +		dma_pool_create(pinstance->ctl_pool_name,
> +				&pinstance->pdev->dev,
>  				sizeof(struct pmcraid_control_block),
>  				PMCRAID_IOARCB_ALIGNMENT, 0);
>  
> @@ -4772,7 +4772,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
>  
>  	for (i = 0; i < PMCRAID_MAX_CMD; i++) {
>  		pinstance->cmd_list[i]->ioa_cb =
> -			pci_pool_alloc(
> +			dma_pool_alloc(
>  				pinstance->control_pool,
>  				GFP_KERNEL,
>  				&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
> diff --git a/drivers/scsi/pmcraid.h b/drivers/scsi/pmcraid.h
> index 568b18a..acf5a7b 100644
> --- a/drivers/scsi/pmcraid.h
> +++ b/drivers/scsi/pmcraid.h
> @@ -755,7 +755,7 @@ struct pmcraid_instance {
>  
>  	/* structures related to command blocks */
>  	struct kmem_cache *cmd_cachep;		/* cache for cmd blocks */
> -	struct pci_pool *control_pool;		/* pool for control blocks */
> +	struct dma_pool *control_pool;		/* pool for control blocks */
>  	char   cmd_pool_name[64];		/* name of cmd cache */
>  	char   ctl_pool_name[64];		/* name of control cache */
>  
> -- 
> 2.9.3
> 

  parent reply	other threads:[~2017-02-08 18:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170208163457.28853-1-romain.perier@collabora.com>
     [not found] ` <20170208163457.28853-2-romain.perier@collabora.com>
2017-02-08 18:20   ` [RFC 01/19] block: DAC960: Replace PCI pool old API Peter Senna Tschudin
     [not found] ` <20170208163457.28853-3-romain.perier@collabora.com>
2017-02-08 18:21   ` [RFC 02/19] dmaengine: pch_dma: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-4-romain.perier@collabora.com>
     [not found]   ` <20170208163457.28853-4-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-08 18:22     ` [RFC 03/19] IB/mthca: " Peter Senna Tschudin
2017-02-08 18:22       ` Peter Senna Tschudin
     [not found] ` <20170208163457.28853-5-romain.perier@collabora.com>
     [not found]   ` <20170208163457.28853-5-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-08 18:23     ` [RFC 04/19] net: e100: " Peter Senna Tschudin
2017-02-08 18:23       ` Peter Senna Tschudin
     [not found] ` <20170208163457.28853-6-romain.perier@collabora.com>
2017-02-08 18:24   ` [RFC 05/19] mlx4: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-7-romain.perier@collabora.com>
2017-02-08 18:26   ` [RFC 06/19] mlx5: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-8-romain.perier@collabora.com>
2017-02-08 18:27   ` [RFC 07/19] wireless: ipw2200: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-9-romain.perier@collabora.com>
2017-02-08 18:28   ` [RFC 08/19] scsi: be2iscsi: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-10-romain.perier@collabora.com>
2017-02-08 18:29   ` [RFC 09/19] scsi: csiostor: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-11-romain.perier@collabora.com>
2017-02-08 18:32   ` [RFC 10/19] scsi: lpfc: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-12-romain.perier@collabora.com>
2017-02-08 18:37   ` [RFC 11/19] scsi: megaraid: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-13-romain.perier@collabora.com>
2017-02-08 18:40   ` [RFC 12/19] scsi: mpt3sas: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-14-romain.perier@collabora.com>
2017-02-08 18:42   ` [RFC 13/19] scsi: mvsas: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-15-romain.perier@collabora.com>
2017-02-08 18:42   ` Peter Senna Tschudin [this message]
     [not found] ` <20170208163457.28853-16-romain.perier@collabora.com>
2017-02-08 18:43   ` [RFC 15/19] usb: gadget: amd5536udc: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-17-romain.perier@collabora.com>
2017-02-08 18:45   ` [RFC 16/19] usb: gadget: net2280: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-18-romain.perier@collabora.com>
2017-02-08 18:45   ` [RFC 17/19] usb: gadget: pch_udc: " Peter Senna Tschudin
     [not found] ` <20170208163457.28853-19-romain.perier@collabora.com>
2017-02-08 18:49   ` [RFC 18/19] PCI: Remove PCI pool macro functions Peter Senna Tschudin
     [not found] ` <20170208163457.28853-20-romain.perier@collabora.com>
2017-02-08 18:55   ` [RFC 19/19] checkpatch: warn for use of old PCI pool API Peter Senna Tschudin
2017-02-08 19:53     ` Joe Perches
     [not found] ` <20170208163457.28853-1-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-08 19:00   ` [RFC 00/19] Replace PCI pool by DMA " Peter Senna Tschudin
2017-02-08 19:00     ` Peter Senna Tschudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208184235.GN16878@collabora.com \
    --to=peter.senna@collabora.com \
    --cc=balbi@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hal.rosenstock@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.senna@collabora.co.uk \
    --cc=romain.perier@collabora.com \
    --cc=sean.hefty@intel.com \
    --cc=stas.yakovlev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.