From: Brian Norris <computersforpeace@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
David Woodhouse <dwmw2@infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy
Date: Wed, 8 Feb 2017 13:16:49 -0800 [thread overview]
Message-ID: <20170208211649.GE94627@google.com> (raw)
In-Reply-To: <0e6b1dc1-5311-91ba-10e3-1a13f866df6b@gmail.com>
On Sat, Feb 04, 2017 at 10:12:35PM +0100, Marek Vasut wrote:
> On 02/03/2017 10:49 AM, Arnd Bergmann wrote:
> > kernelci.org reports a warning for this driver, as it copies a local
> > variable into a 'const char *' string:
> >
> > drivers/mtd/maps/pmcmsp-flash.c:149:30: warning: passing argument 1 of 'strncpy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >
> > Using kstrndup() simplifies the code and avoids the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
Applied to l2-mtd.git.
next prev parent reply other threads:[~2017-02-08 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:49 [PATCH] mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy Arnd Bergmann
2017-02-04 21:12 ` Marek Vasut
2017-02-08 21:16 ` Brian Norris [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-10 19:57 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208211649.GE94627@google.com \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.