From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Cyrille Pitchen" <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V4] mtd: bcm47xxsflash: support reading flash out of mapping window
Date: Wed, 8 Feb 2017 15:12:51 -0800 [thread overview]
Message-ID: <20170208231251.GM94627@google.com> (raw)
In-Reply-To: <20170208230921.GL94627@google.com>
On Wed, Feb 08, 2017 at 03:09:21PM -0800, Brian Norris wrote:
> On Wed, Feb 08, 2017 at 11:53:44PM +0100, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > For reading flash content we use MMIO but it's possible to read only
> > first 16 MiB this way. It's simply an arch design/limitation.
> > To support flash sizes bigger than 16 MiB implement indirect access
> > using ChipCommon registers.
> > This has been tested using MX25L25635F.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > Acked-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > V2: Simplify line writing to buf
> > Add some trivial comment for OPCODE_ST_READ4B
> > Both requested by Marek
> > V3: Use as much as possible MMIO access for reads crossing boundary
> > V4: Add missing buf increment (thanks Brian!)
>
> Presumably you tested for this case now? Seems like quick turnaround :)
Anyway, LGTM. Applied to l2-mtd.git.
prev parent reply other threads:[~2017-02-08 23:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 11:51 [PATCH V3] mtd: bcm47xxsflash: support reading flash out of mapping window Rafał Miłecki
2017-02-04 22:01 ` Marek Vasut
2017-02-04 22:27 ` Rafał Miłecki
2017-02-04 22:31 ` Marek Vasut
2017-02-08 19:35 ` Brian Norris
2017-02-08 22:53 ` Rafał Miłecki
2017-02-08 22:53 ` [PATCH V4] " Rafał Miłecki
2017-02-08 23:09 ` Brian Norris
2017-02-08 23:12 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208231251.GM94627@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.