From: Eric Biggers <ebiggers3@gmail.com>
To: Hoeun Ryu <hoeun.ryu@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Ingo Molnar <mingo@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Mateusz Guzik <mguzik@redhat.com>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] [PATCH v2 1/2] fork: free vmapped stacks in cache when cpus are offline
Date: Wed, 8 Feb 2017 20:22:29 -0800 [thread overview]
Message-ID: <20170209042229.GA4311@zzz> (raw)
In-Reply-To: <1486613040-30555-1-git-send-email-hoeun.ryu@gmail.com>
Hi Hoeun,
On Thu, Feb 09, 2017 at 01:03:46PM +0900, Hoeun Ryu wrote:
> +static int free_vm_stack_cache(unsigned int cpu)
> +{
> + int i;
> +
> + for (i = 0; i < NR_CACHED_STACKS; i++) {
> + struct vm_struct *vm_stack = this_cpu_read(cached_stacks[i]);
> + if (!vm_stack)
> + continue;
> +
> + vfree(vm_stack->addr);
> + this_cpu_write(cached_stacks[i], NULL);
> + }
> +
> + return 0;
> +}
Doesn't this need to free the stacks for the 'cpu' that's passed in, instead of
"this" CPU?
- Eric
next prev parent reply other threads:[~2017-02-09 4:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 4:03 [kernel-hardening] [PATCH v2 1/2] fork: free vmapped stacks in cache when cpus are offline Hoeun Ryu
2017-02-09 4:03 ` Hoeun Ryu
2017-02-09 4:03 ` [kernel-hardening] [PATCH v2 2/2] fork: make number of cached stacks (vmapped) configurable using Kbuild Hoeun Ryu
2017-02-09 4:03 ` Hoeun Ryu
2017-02-09 4:26 ` [kernel-hardening] " Eric Biggers
2017-02-09 8:40 ` [kernel-hardening] " Michal Hocko
2017-02-09 8:40 ` Michal Hocko
2017-02-09 13:36 ` [kernel-hardening] " Hoeun Ryu
2017-02-09 13:36 ` Hoeun Ryu
2017-02-09 4:22 ` Eric Biggers [this message]
2017-02-09 13:35 ` [kernel-hardening] [PATCH v2 1/2] fork: free vmapped stacks in cache when cpus are offline Hoeun Ryu
2017-02-09 7:28 ` [kernel-hardening] " kbuild test robot
2017-02-09 7:28 ` kbuild test robot
2017-02-09 8:01 ` [kernel-hardening] " kbuild test robot
2017-02-09 8:01 ` kbuild test robot
2017-02-09 8:38 ` [kernel-hardening] " Michal Hocko
2017-02-09 8:38 ` Michal Hocko
2017-02-09 13:36 ` [kernel-hardening] " Hoeun Ryu
2017-02-09 13:36 ` Hoeun Ryu
2017-02-09 10:26 ` [kernel-hardening] " kbuild test robot
2017-02-09 10:26 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209042229.GA4311@zzz \
--to=ebiggers3@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hoeun.ryu@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mguzik@redhat.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.