All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin
Date: Thu, 9 Feb 2017 08:58:41 +0100	[thread overview]
Message-ID: <20170209075841.GA6578@lst.de> (raw)
In-Reply-To: <20170209075322.GA6824@birch.djwong.org>

On Wed, Feb 08, 2017 at 11:53:22PM -0800, Darrick J. Wong wrote:
> Testing isn't done yet, but xfs/222 seems to be blowing up at
> ASSERT(!rwsem_is_locked(&inode->i_rwsem)) in xfs_super.c fairly
> consistently with blocksize=1k.  I haven't been able to reproduce it
> quickly (i.e. without running the whole test suite) so I can't tell if
> that's a side effect of something else blowing up or what.  generic/300
> seems to blow up periodically and then blows the same assert on umount,
> also in the 1k case.  xfs/348 fuzzes the fs, causes "kernel memory
> exposure!" BUGs and then asserts with the same i_rwsem thing.

I'll take a look at the umount assert while you're asleep.  348 is
a pretty new test, so I doubt it's a regrewssion.

> (You'll note I didn't merge the duplicate "xfs: improve handling of busy
> extents in the low-level allocator"; if you want that done, please let me
> know.)

Yes, it should be folded into the first patch of that name and descriptions.
It contains the fixups that Brian requested.

  reply	other threads:[~2017-02-09  7:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06  7:47 reflink direct I/O improvements V3 Christoph Hellwig
2017-02-06  7:47 ` [PATCH 1/4] xfs: introduce xfs_aligned_fsb_count Christoph Hellwig
2017-02-06  7:47 ` [PATCH 2/4] xfs: return the converted extent in __xfs_reflink_convert_cow Christoph Hellwig
2017-02-06  7:47 ` [PATCH 3/4] xfs: go straight to real allocations for direct I/O COW writes Christoph Hellwig
2017-02-07  1:12   ` Darrick J. Wong
2017-02-06  7:47 ` [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin Christoph Hellwig
2017-02-07  1:41   ` Darrick J. Wong
2017-02-09  7:21     ` Christoph Hellwig
2017-02-09  7:53       ` Darrick J. Wong
2017-02-09  7:58         ` Christoph Hellwig [this message]
2017-02-09  8:00           ` Christoph Hellwig
2017-02-09 17:22           ` Christoph Hellwig
2017-02-06 18:41 ` reflink direct I/O improvements V3 Darrick J. Wong
2017-02-06 20:55   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2017-02-01 21:42 reflink direct I/O improvements V2 Christoph Hellwig
2017-02-01 21:42 ` [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin Christoph Hellwig
2017-02-03  0:55   ` Darrick J. Wong
2017-02-03 10:53     ` Christoph Hellwig
2017-02-05 20:13       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209075841.GA6578@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.