All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: David Miller <davem@davemloft.net>,
	Willem de Bruijn <willemb@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	jarno@ovn.org, philip.pettersson@gmail.com,
	weongyo.linux@gmail.com, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>
Subject: Re: net/packet: use-after-free in packet_rcv_fanout
Date: Thu, 9 Feb 2017 07:12:20 -0800	[thread overview]
Message-ID: <20170209151220.GA4843@oracle.com> (raw)
In-Reply-To: <CACT4Y+a2tTARdXKtjtWny9hAPc9b8Q-v8ya3TOV-T+8s=PR2HQ@mail.gmail.com>

On (02/09/17 14:14), Dmitry Vyukov wrote:
> 
> Call Trace:
   :
>  packet_rcv_has_room+0x25/0xb0 net/packet/af_packet.c:1308
>  fanout_demux_rollover+0x3bb/0x6b0 net/packet/af_packet.c:1388
>  packet_rcv_fanout+0x674/0x800 net/packet/af_packet.c:1490
>  dev_queue_xmit_nit+0x73a/0xa90 net/core/dev.c:1898
    :
>  tcp_sendmsg_fastopen net/ipv4/tcp.c:1110 [inline]
    :

looks like a race between a NIT socket (tcpdump, maybe?) that is closing,
and a standard tcp socket.. packet_release() takes the po->bind_lock
to remove the socket from the ptype_all NIT queue. but how does
that sync with the Tx path for other af_inet/af_inet6 sockets? 

--Sowmini

  reply	other threads:[~2017-02-09 15:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 13:14 net/packet: use-after-free in packet_rcv_fanout Dmitry Vyukov
2017-02-09 15:12 ` Sowmini Varadhan [this message]
2017-02-09 15:17   ` Eric Dumazet
2017-02-10  1:24 ` Cong Wang
2017-02-10  3:19   ` Eric Dumazet
2017-02-10  3:23     ` Eric Dumazet
2017-02-10 17:49       ` Cong Wang
2017-02-10 17:59         ` Eric Dumazet
2017-02-10 18:02           ` Cong Wang
2017-02-10 18:15             ` Eric Dumazet
2017-02-10 18:02           ` Eric Dumazet
2017-02-10 18:34             ` Cong Wang
2017-02-13  1:42             ` Sowmini Varadhan
2017-02-13 15:17               ` Dmitry Vyukov
2017-02-17 19:27                 ` Cong Wang
2017-02-10  3:33     ` Sowmini Varadhan
2017-02-10  4:18       ` Eric Dumazet
2017-02-10 18:00       ` Cong Wang
2017-02-10 19:16         ` Sowmini Varadhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209151220.GA4843@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=jarno@ovn.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=philip.pettersson@gmail.com \
    --cc=syzkaller@googlegroups.com \
    --cc=weongyo.linux@gmail.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.