From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdBITK7 (ORCPT ); Thu, 9 Feb 2017 14:10:59 -0500 Received: from mail.kernel.org ([198.145.29.136]:49816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbdBITK5 (ORCPT ); Thu, 9 Feb 2017 14:10:57 -0500 Date: Thu, 9 Feb 2017 16:02:07 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Adrian Hunter , Alexander Shishkin , Jiri Olsa , Linux Kernel Mailing List Subject: Re: Intel PT decoder switch case fallthrough cases reported by gcc 7 Message-ID: <20170209190206.GA15066@kernel.org> References: <20170209165039.GA2488@kernel.org> <20170209182519.GR26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209182519.GR26852@two.firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Feb 09, 2017 at 10:25:19AM -0800, Andi Kleen escreveu: > On Thu, Feb 09, 2017 at 01:50:39PM -0300, Arnaldo Carvalho de Melo wrote: > > Hi, > > > > I've updated the container with Fedora Rawhide I use to build > > tools/perf/ and samples/bcc/ and it now comes with gcc 7, where I get > > things like: > > FWIW, but it just shows that you should never ship software with -Werror > enabled. New compiler releases add new warnings, and you just randomly > break the build for users who use newer compilers. > > It's ok to use in your own builds, but should never be default. > > The kernel gets it right, but perf is wrong here. But what about my question? Do you think the changes are ok? I actually made all be fallthrough, i.e. considered that the existing code was ok. - Arnaldo