From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5base: select qt-libpng in case builtin freetype library is used
Date: Thu, 9 Feb 2017 22:34:18 +0100 [thread overview]
Message-ID: <20170209223418.48c2be5e@gmx.net> (raw)
In-Reply-To: <20170209221821.00c1dd4b@free-electrons.com>
Hello Thomas,
On Thu, 9 Feb 2017 22:18:21 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu, 9 Feb 2017 18:40:08 +0100, Peter Seiderer wrote:
>
> > diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> > index 2cf0331b0..afe373123 100644
> > --- a/package/qt5/qt5base/qt5base.mk
> > +++ b/package/qt5/qt5base/qt5base.mk
> > @@ -149,7 +149,12 @@ QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig)
> > QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_GIF),,-no-gif)
> > QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_JPEG),-system-libjpeg,-no-libjpeg)
> > QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_JPEG),jpeg)
> > +ifeq ($(BR2_QT5_VERSION_5_6)$(BR2_PACKAGE_QT5BASE_FONTCONFIG),)
> > +# qt-5.8.0 freetype needs libpng support
> > +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_PNG),-system-libpng,-qt-libpng)
>
> Are you sure we need -qt-libpng in all cases when there is no
> fontconfig support? Isn't it only needed when the GUI module is enabled?
>
Interesting question ;-), but I think your are right...
> Also, why is the builtin freetype library used? We generally don't like
> to use the builtin libraries. Can we instead rely on external libpng
> and external freetype?
Historic reasons (you did not add this feature back in 2013.... ;-))?
But same as Arnout Vandecappelle pointed out....
Will try to generate a patch...
Regards,
Peter
>
> Thanks,
>
> Thomas
prev parent reply other threads:[~2017-02-09 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 17:40 [Buildroot] [PATCH v1] qt5base: select qt-libpng in case builtin freetype library is used Peter Seiderer
2017-02-09 21:18 ` Thomas Petazzoni
2017-02-09 21:34 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209223418.48c2be5e@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.