From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jason Baron <jbaron@akamai.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] jump_label: mark __start/stop___jump_table const
Date: Thu, 9 Feb 2017 23:40:43 +0200 [thread overview]
Message-ID: <20170209234001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1486674463-25784-1-git-send-email-mst@redhat.com>
On Thu, Feb 09, 2017 at 11:11:32PM +0200, Michael S. Tsirkin wrote:
> Attempts to assign values through these pointers would fail.
> Mark them const to make sure the failure is compile time.
>
> Cc: Jason Baron <jbaron@akamai.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Hmm this produces a bunch of warnings that I managed
to somehow miss. Self-Nack. Pls disregard.
> ---
> include/linux/jump_label.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index a0547c5..48ed83f 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -132,8 +132,8 @@ static __always_inline bool static_key_true(struct static_key *key)
> return !arch_static_branch(key, true);
> }
>
> -extern struct jump_entry __start___jump_table[];
> -extern struct jump_entry __stop___jump_table[];
> +extern const struct jump_entry __start___jump_table[];
> +extern const struct jump_entry __stop___jump_table[];
>
> extern void jump_label_init(void);
> extern void jump_label_lock(void);
> --
> MST
next prev parent reply other threads:[~2017-02-09 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 21:11 [PATCH] jump_label: mark __start/stop___jump_table const Michael S. Tsirkin
2017-02-09 21:40 ` Michael S. Tsirkin [this message]
2017-02-10 5:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209234001-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.