From: Brian Norris <computersforpeace@gmail.com>
To: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
David Woodhouse <dwmw2@infradead.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Richard Weinberger <richard@nod.at>,
Mark Brown <broonie@kernel.org>
Subject: Re: [GIT PULL] mtd: spi-nor: Changes for 4.11
Date: Thu, 9 Feb 2017 18:46:24 -0800 [thread overview]
Message-ID: <20170210024624.GA142725@google.com> (raw)
In-Reply-To: <20170208190939.GA97840@google.com>
On Wed, Feb 08, 2017 at 11:09:39AM -0800, Brian Norris wrote:
> On Wed, Feb 08, 2017 at 11:36:10AM +0100, Cyrille Pitchen wrote:
> > Le 08/02/2017 à 06:52, Heiner Kallweit a écrit :
> > > Am 08.02.2017 um 02:09 schrieb Marek Vasut:
> > >> On 02/07/2017 04:31 PM, Cyrille Pitchen wrote:
> > [...]
> > >>> Heiner Kallweit (1):
> > >>> mtd: m25p80: consider max message size in m25p80_read
> > >>
> > >> I cannot say I'm super-happy about this particular patch, still ...
> > >>
> > > W/o it at least the fsl-espi driver is broken for transfers >= 64kB.
> > >
[...]
> One thing I do object to: why is this change marked for stable? It's not
> our fault you broke your duct-taped-together SPI driver in 4.9. I don't
> think backporting features is the way to satisfy the -stable
> requirements. Maybe some reverts would be the right way...
OK, I've reviewed the rest of the pull request as well as I care for.
I still have this one objection: I don't think this belongs in -stable.
Am I crazy? Or else Cyrille, can you remove the stable tag and resend?
Or I can go rewrite your history for you and do this...
Brian
P.S. Also, this stuck out at me in the diffs, and checkpatch complained
too. Not a real big deal:
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each
line
#42: FILE: drivers/mtd/spi-nor/spi-nor.c:83:
+ * ATMEL flashes)
+ */
total: 0 errors, 1 warnings, 264 lines checked
next prev parent reply other threads:[~2017-02-10 2:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 15:31 [GIT PULL] mtd: spi-nor: Changes for 4.11 Cyrille Pitchen
2017-02-08 1:09 ` Marek Vasut
2017-02-08 5:52 ` Heiner Kallweit
2017-02-08 10:36 ` Cyrille Pitchen
2017-02-08 19:09 ` Brian Norris
2017-02-08 19:22 ` Mark Brown
2017-02-08 20:39 ` Brian Norris
2017-02-09 1:33 ` Mark Brown
2017-02-08 19:40 ` Michal Suchanek
2017-02-08 20:03 ` Heiner Kallweit
2017-02-08 20:05 ` Mark Brown
2017-02-08 19:53 ` Heiner Kallweit
2017-02-10 2:46 ` Brian Norris [this message]
2017-02-10 6:39 ` Heiner Kallweit
2017-02-10 13:07 ` Marek Vasut
2017-02-10 17:56 ` Heiner Kallweit
2017-02-15 22:24 ` Marek Vasut
2017-02-10 13:00 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210024624.GA142725@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=hkallweit1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.