From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752447AbdBJIS1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 03:18:27 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:34689 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751045AbdBJIQy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 03:16:54 -0500
Date: Fri, 10 Feb 2017 09:16:50 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Wei Yongjun <weiyongjun1@huawei.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] sched/x86: Remove duplicated include from itmt.c
Message-ID: <20170210081650.GB17987@gmail.com>
References: <20170209151512.28176-1-weiyj.lk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170209151512.28176-1-weiyj.lk@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  arch/x86/kernel/itmt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c
> index f73f475..b5ccc9b 100644
> --- a/arch/x86/kernel/itmt.c
> +++ b/arch/x86/kernel/itmt.c
> @@ -20,7 +20,6 @@
>   * frequency under ITMT.
>   */
>  
> -#include <linux/sched.h>
>  #include <linux/cpumask.h>
>  #include <linux/cpuset.h>
>  #include <linux/mutex.h>

Firstly, we generally use 'larger' headers first, i.e. sched.h, mm.h, etc.

Secondly, this:

#include <linux/sched.h>
#include <linux/cpumask.h>
#include <linux/cpuset.h>
#include <linux/mutex.h>
#include <linux/sysctl.h>
#include <linux/nodemask.h>

... can probably be further reduced, because for example sched.h already includes 
some of these headers.

I.e. instead of a mindless single liner that helps no-one, try to improve the code 
for real...

Thanks,

	Ingo