All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Your build results for 2017-02-09
Date: Fri, 10 Feb 2017 11:26:06 +0100	[thread overview]
Message-ID: <20170210112606.1f17fd02@free-electrons.com> (raw)
In-Reply-To: <A9140E91EDA627489354A41A7EE118CA33CCBD@sv08ultra002.ultratronik.de>

Hello,

On Fri, 10 Feb 2017 09:52:09 +0000, Naumann Andreas wrote:

> I've actually sent a patch for this earlier in '[Buildroot] [PATCH v4
> 10/10] poppler: Compile with -std=c++11'. Unfortunately I forgot it
> in v5. Is this enough or do you want me to resend it?

OK, I found it again in patchwork:

  http://patchwork.ozlabs.org/patch/708239/

But this patch has an issue: if a package needs C++11 support then it
needs to have a BR2_TOOLCHAIN_GCC_AT_LEAST_XYZ dependency.

But this raises an even more fundamental issue: there is *nothing* in
poppler that indicates it can depend on Qt5. There is some logic for
Qt4, but nothing for Qt5.

So: the dependency on Qt5 should be made explicit, and should take care
of the fact that Qt5 needs C++11 support, and therefore a reasonably
recent C++ compiler.

Could you work on this?

Alternatively, if you don't care/use Qt5 support in Poppler, you can
also just pass the appropriate --disable-<foo> option to
unconditionally disable Qt5 support.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

       reply	other threads:[~2017-02-10 10:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170210072859.4656F20BAB@mail.free-electrons.com>
     [not found] ` <CALdGskLbBc1Vx9Ju8ZhUJvRa5r6q83=N-qukFygmS-eZz79i8Q@mail.gmail.com>
     [not found]   ` <20170210093759.33285cd1@free-electrons.com>
     [not found]     ` <A9140E91EDA627489354A41A7EE118CA33CCBD@sv08ultra002.ultratronik.de>
2017-02-10 10:26       ` Thomas Petazzoni [this message]
2017-02-10 10:47         ` [Buildroot] [autobuild.buildroot.net] Your build results for 2017-02-09 Andreas Naumann
2017-02-10 10:51           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210112606.1f17fd02@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.