All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Liu <b-liu@ti.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: usb: musb: add code comment for clarification
Date: Fri, 10 Feb 2017 07:22:29 -0600	[thread overview]
Message-ID: <20170210132229.GA3446@uda0271908> (raw)
In-Reply-To: <20170210035654.GA11033@embeddedgus>

On Thu, Feb 09, 2017 at 09:56:54PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> 

Don't need 'drivers:' in the subject.

> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/usb/musb/musb_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 892088f..1aec986 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb)
>  
>  			return;
>  		}
> +		/* FALLTHROUGH */

		/* fall through */
as in CodingStyle.

>  	case MUSB_QUIRK_A_DISCONNECT_19:
>  		if (musb->quirk_retries--) {
>  			musb_dbg(musb,
> -- 

Regards,
-Bin.

       reply	other threads:[~2017-02-10 13:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170210035654.GA11033@embeddedgus>
2017-02-10 13:22 ` Bin Liu [this message]
2017-02-11  0:57   ` [PATCH] usb: musb: add code comment for clarification Gustavo A. R. Silva
2017-02-14 17:31     ` Greg KH
2017-02-14 18:12       ` Gustavo A. R. Silva
2017-02-14 18:20         ` [PATCH v2] " Gustavo A. R. Silva
2017-02-14 18:25           ` Greg KH
2017-02-14 18:54             ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210132229.GA3446@uda0271908 \
    --to=b-liu@ti.com \
    --cc=garsilva@embeddedor.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.