From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 7/7] drm: Rename connector list iterator API Date: Fri, 10 Feb 2017 18:48:06 +0100 Message-ID: <20170210174806.GA5995@ulmo.ba.sec> References: <20170210171414.21768-1-thierry.reding@gmail.com> <20170210171414.21768-8-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1609566531==" Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id C16AA6ED47 for ; Fri, 10 Feb 2017 17:48:10 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id c85so8437959wmi.1 for ; Fri, 10 Feb 2017 09:48:10 -0800 (PST) In-Reply-To: <20170210171414.21768-8-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Christian =?utf-8?B?S8O2bmln?= List-Id: dri-devel@lists.freedesktop.org --===============1609566531== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 10, 2017 at 06:14:14PM +0100, Thierry Reding wrote: [...] > /** > - * drm_connector_list_iter_get - initialize a connector_list iterator > + * drm_connector_list_iter_begin - initialize a connector_list iterator > * @dev: DRM device > * @iter: connector_list iterator > * > * Sets @iter up to walk the &drm_mode_config.connector_list of @dev. @iter > - * must always be cleaned up again by calling drm_connector_list_iter_put(). > + * must always be cleaned up again by calling drm_connector_list_iter_end(). > * Iteration itself happens using drm_connector_list_iter_next() or > * drm_for_each_connector_iter(). > */ > -void drm_connector_list_iter_get(struct drm_device *dev, > - struct drm_connector_list_iter *iter) > +void drm_connector_list_iter_begin(struct drm_device *dev, > + struct drm_connector_list_iter *iter) > { > iter->dev = dev; > iter->conn = NULL; > lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, _RET_IP_); > } > -EXPORT_SYMBOL(drm_connector_list_iter_get); > +EXPORT_SYMBOL(drm_connector_list_iter_end); Erm... this should obviously have been drm_connector_list_iter_begin, no idea why the build tests didn't catch this on the first run. Thierry --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlid/NEACgkQ3SOs138+ s6GUWxAAgXdmqe04D0i9rwbkpzP/P0+yJ/SbOKlZBKrCQTDtrYV5tT5+mD1hRVi9 3x+hS9xhXoZN5YnIojbE/AMn+AgJYpJaGwNYyVs1gqiNmadz/bKLOE+aSmT/eWii wLbPmr2jKVW2ifvTyZe1eM5vCUFK7Y5HGkyIfCihO3R5cXzcTkYdawks7dkFXT5z MAszDBOML41e8PVb7MVMV9i1pTcIxNxVWaPjjaQHe5sefet5sZup20dSVveKkbnq 4EXaSC7Jdtcq8TaB4kvDRBBP87/v5N42VUoQ4df63CjivGDqpuWQKlIpfxciMOwn ptUhWJXQUmHDY1nKjFZOqFMt65iQ0HbMTv/SkyP73ciq86L/oMtNBxxvp8idC6Qb o5fGd1JBRseFR0slDNk8qndPv6Ru4Dv3PAQgROryDQWSbzr7oPwl+bB//YSkNRcU 4CWPOSuRLQ/zgq6EShSTzCB7XzJXioTNe8mbnwS0s+0xhIU2Eusz+rwkLXKh4dWI usfoQle4Q1NyewZ6OcZuIFOqbL0UtryxaBzw/0h0MMWCz5xiJrrUOBRe/o58li25 5fQ8kCsrvvgRbpeXt1sH/rdGJRCnA6JSG5PvfvEuPLfdJ5y7J23Zhjq2VPMWhGq7 fQfka418w6Jtq9rBFHHf1gl5DHMuasSjwmsu2kLIopNsve6porE= =hpu8 -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1-- --===============1609566531== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1609566531==--