From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] package/mpd: add choice between version 0.19 and 0.20
Date: Sat, 11 Feb 2017 15:25:06 +0100 [thread overview]
Message-ID: <20170211152506.476e9e1b@free-electrons.com> (raw)
In-Reply-To: <1486710272.9565.3.camel@embedded.rocks>
Hello,
On Fri, 10 Feb 2017 08:04:32 +0100, J?rg Krause wrote:
> > I am not sure we want to support a version choice for mpd just for
> > the
> > sake of NIOSII, ARMv4, ARMv5 and SPARCv8.
>
> I'm using an ARMv5 board with MPD?myself. I really like to have that
> package available for this arch in the next Buildroot release.
OK, makes sense. So could you send an updated version with the following
changes:
- Hash for 0.19, as you mentioned.
- Removal of visible options. Just use 0.20 if possible (recent enough
and non-buggy compiler) and fallback to 0.19 if not. A visible
choice is really not needed for this. Also, if you use any
Config.in option for that, they should be prefixed BR2_PACKAGE_MPD
and not BR2_MPD like your patch was doing.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-11 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 17:47 [Buildroot] [PATCH 0/6] Deal with GCC PR libstdc++/64735 Jörg Krause
2017-02-09 17:47 ` [Buildroot] [PATCH 1/6] toolchain: add option for toolchains affected by " Jörg Krause
2017-02-09 20:30 ` Thomas Petazzoni
2017-02-10 6:52 ` Jörg Krause
2017-02-09 17:47 ` [Buildroot] [PATCH 2/6] arch: mark NIOS II as " Jörg Krause
2017-02-09 20:32 ` Thomas Petazzoni
2017-02-09 17:47 ` [Buildroot] [PATCH 3/6] arch/arm: mark ARMv{4, 5} " Jörg Krause
2017-02-09 17:47 ` [Buildroot] [PATCH 4/6] arch/sparc: mark SPARCv8 " Jörg Krause
2017-02-09 17:47 ` [Buildroot] [PATCH 5/6] package/mpd: " Jörg Krause
2017-02-09 20:33 ` Thomas Petazzoni
2017-02-09 17:47 ` [Buildroot] [PATCH 6/6] package/mpd: add choice between version 0.19 and 0.20 Jörg Krause
2017-02-09 20:34 ` Thomas Petazzoni
2017-02-10 7:04 ` Jörg Krause
2017-02-11 14:25 ` Thomas Petazzoni [this message]
2017-02-10 7:34 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211152506.476e9e1b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.