From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Tejun Heo Date: Sun, 12 Feb 2017 13:32:38 +0900 From: Tejun Heo To: Jan Kara Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Dan Williams , Thiago Jung Bauermann , NeilBrown Subject: Re: [PATCH 05/10] writeback: Generalize and standardize I_SYNC waiting function Message-ID: <20170212043238.GE29323@mtj.duckdns.org> References: <20170209124433.2626-1-jack@suse.cz> <20170209124433.2626-6-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170209124433.2626-6-jack@suse.cz> List-ID: On Thu, Feb 09, 2017 at 01:44:28PM +0100, Jan Kara wrote: > __inode_wait_for_writeback() waits for I_SYNC on inode to get cleared. > There's nothing specific regarting I_SYNC for that function. Generalize > it so that we can use it also for I_WB_SWITCH bit. Also the function > uses __wait_on_bit() unnecessarily. Switch it to wait_on_bit() to remove > some code. > > Signed-off-by: Jan Kara Acked-by: Tejun Heo Thanks. -- tejun