From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra/ccache: avoid color diagnostics with GCC older than v4.9
Date: Sun, 12 Feb 2017 13:14:43 +0100 [thread overview]
Message-ID: <20170212131443.155d5a7d@free-electrons.com> (raw)
In-Reply-To: <20170212100800.GC4533@free.fr>
Hello,
On Sun, 12 Feb 2017 11:08:00 +0100, Yann E. MORIN wrote:
> > Another option would be to adjust this in ccache itself at compile time
> > (i.e when ccache gets built) rather than having to pass this additional
> > GCC_COLORS variable in the environment when building things. This way
> > we would be absolutely sure -fdiagnostics-color will never be passed.
> > Hence why I'd like the feedback from other developers.
>
> But there is no config option to disable that in ccache. The behaviour
> is hard-coded; we would need a patch to disable that.
We could sed it like we already do in package/ccache/ccache.mk for
other things.
> And we might need that for the host as well, no?
>
> ifeq ($(BR2_HOST_GCC_AT_LEAST_4_9),)
> HOST_MAKE_ENV += GCC_COLORS=""
> endif
Check Carlos original patch, it was there.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-12 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 13:34 [Buildroot] [PATCH] infra/ccache: avoid color diagnostics with GCC older than v4.9 Carlos Santos
2017-02-11 15:38 ` Thomas Petazzoni
2017-02-12 10:08 ` Yann E. MORIN
2017-02-12 12:14 ` Thomas Petazzoni [this message]
2017-02-12 12:33 ` Yann E. MORIN
2017-02-12 12:59 ` Thomas Petazzoni
2017-02-12 13:08 ` Yann E. MORIN
2017-02-12 13:10 ` Thomas Petazzoni
2017-02-12 11:33 ` [Buildroot] [PATCH v2] " Carlos Santos
2017-02-12 12:34 ` Yann E. MORIN
2017-02-12 14:14 ` Yann E. MORIN
2017-02-12 14:55 ` Carlos Santos
2017-02-12 17:21 ` Yann E. MORIN
2017-02-12 17:22 ` Thomas Petazzoni
2017-02-12 17:28 ` Yann E. MORIN
2017-02-13 22:41 ` Carlos Santos
2017-02-14 16:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212131443.155d5a7d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.